Attention is currently required from: Felix Held, yuchi.chen@intel.com.
Angel Pons has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/85012?usp=email )
Change subject: soc/intel/common/block/itss: Route PCI INT pin to PIRQ using PIR
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/common/block/itss/itss.c:
https://review.coreboot.org/c/coreboot/+/85012/comment/904183e3_33ac7aeb?usp... :
PS5, Line 138: enum pirq itss_get_dev_pirq(struct device *dev, enum pci_pin pin)
This function is used to return which PIRQ a device INT pin is routed to. In https://review. […]
Huh, I don't see `itss_get_dev_pirq` getting called in CB:85013 though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85012?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If911b34c506a4a3657b873baab33814c1a7d674b
Gerrit-Change-Number: 85012
Gerrit-PatchSet: 6
Gerrit-Owner: yuchi.chen@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 11 Nov 2024 07:26:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: yuchi.chen@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com