Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39521 )
Change subject: util/inteltool: add code for dumping thermal registers ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39521/5/util/inteltool/thermal.c File util/inteltool/thermal.c:
https://review.coreboot.org/c/coreboot/+/39521/5/util/inteltool/thermal.c@11... PS5, Line 118: pci_read_long is this a 64-bit read?
https://review.coreboot.org/c/coreboot/+/39521/5/util/inteltool/thermal.c@16... PS5, Line 166: ThermalBASE Isn't this TBAR
https://review.coreboot.org/c/coreboot/+/39521/5/util/inteltool/thermal.c@17... PS5, Line 176: thermalbase+ This is redundant
-
Angel Pons (Code Review)