[XS] Change in coreboot[main]: acpi: introduce and use ACPI_MADT_PCAT_COMPAT define

[Nico Huber (Code Review)]

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82640?usp=email )

Change subject: acpi: introduce and use ACPI_MADT_PCAT_COMPAT define
......................................................................

acpi: introduce and use ACPI_MADT_PCAT_COMPAT define

The multiple APIC flags table from the ACPI specification version 6.4
was used as a reference.

Signed-off-by: Felix Held 
Change-Id: I36f67ca21465bc8753bb36896ee05669de6de333
Reviewed-on: https://review.coreboot.org/c/coreboot/+/82640
Reviewed-by: Nico Huber 
Reviewed-by: Elyes Haouas 
Tested-by: build bot (Jenkins) 
---
M src/acpi/acpi_apic.c
M src/include/acpi/acpi.h
2 files changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Nico Huber: Looks good to me, approved
  Elyes Haouas: Looks good to me, approved
  build bot (Jenkins): Verified

diff --git a/src/acpi/acpi_apic.c b/src/acpi/acpi_apic.c
index 2b3402a..9098811 100644
--- a/src/acpi/acpi_apic.c
+++ b/src/acpi/acpi_apic.c
@@ -234,7 +234,7 @@
    madt->lapic_addr = cpu_get_lapic_addr();

if (CONFIG(ACPI_HAVE_PCAT_8259))
-		madt->flags |= 1;
+		madt->flags |= ACPI_MADT_PCAT_COMPAT;

if (CONFIG(ACPI_COMMON_MADT_LAPIC))
    	current = acpi_create_madt_lapics_with_nmis(current);
diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h
index d6c30c1..0e5b4b2 100644
--- a/src/include/acpi/acpi.h
+++ b/src/include/acpi/acpi.h
@@ -458,6 +458,9 @@
    u32 flags;			/* Multiple APIC flags */
 } __packed acpi_madt_t;

+/* MADT Feature Flags */
+#define ACPI_MADT_PCAT_COMPAT	(1 << 0)
+
 /*
  * LPIT (Low Power Idle Table)
  * Conforms to "Intel Low Power S0 Idle" specification, rev 002 from July 2017.