HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42349 )
Change subject: src: Remove unused 'include <boot_device.h>' ......................................................................
src: Remove unused 'include <boot_device.h>'
Change-Id: I5589fdeade7f69995adf1c983ced13773472be74 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/security/vboot/vboot_common.c M src/soc/nvidia/tegra124/spi.c M src/soc/nvidia/tegra210/spi.c 3 files changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/42349/1
diff --git a/src/security/vboot/vboot_common.c b/src/security/vboot/vboot_common.c index 1cddeeb..9a49510 100644 --- a/src/security/vboot/vboot_common.c +++ b/src/security/vboot/vboot_common.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <boot_device.h> #include <cbmem.h> #include <console/cbmem_console.h> #include <reset.h> diff --git a/src/soc/nvidia/tegra124/spi.c b/src/soc/nvidia/tegra124/spi.c index adf0248..18ea626 100644 --- a/src/soc/nvidia/tegra124/spi.c +++ b/src/soc/nvidia/tegra124/spi.c @@ -4,7 +4,6 @@ #include <arch/cache.h> #include <device/mmio.h> #include <assert.h> -#include <boot_device.h> #include <console/console.h> #include <delay.h> #include <soc/addressmap.h> diff --git a/src/soc/nvidia/tegra210/spi.c b/src/soc/nvidia/tegra210/spi.c index 8fde9c2..067d77e 100644 --- a/src/soc/nvidia/tegra210/spi.c +++ b/src/soc/nvidia/tegra210/spi.c @@ -4,7 +4,6 @@ #include <arch/cache.h> #include <device/mmio.h> #include <assert.h> -#include <boot_device.h> #include <console/console.h> #include <delay.h> #include <spi-generic.h>
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42349 )
Change subject: src: Remove unused 'include <boot_device.h>' ......................................................................
Patch Set 3: Code-Review+2
Hello build bot (Jenkins), Angel Pons, Julius Werner, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42349
to look at the new patch set (#4).
Change subject: src: Remove unused 'include <boot_device.h>' ......................................................................
src: Remove unused 'include <boot_device.h>'
Change-Id: I5589fdeade7f69995adf1c983ced13773472be74 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/security/vboot/vboot_common.c M src/soc/nvidia/tegra124/spi.c M src/soc/nvidia/tegra210/spi.c 3 files changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/42349/4
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42349 )
Change subject: src: Remove unused 'include <boot_device.h>' ......................................................................
Patch Set 6: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42349 )
Change subject: src: Remove unused 'include <boot_device.h>' ......................................................................
src: Remove unused 'include <boot_device.h>'
Change-Id: I5589fdeade7f69995adf1c983ced13773472be74 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/42349 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/security/vboot/vboot_common.c M src/soc/nvidia/tegra124/spi.c M src/soc/nvidia/tegra210/spi.c 3 files changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/security/vboot/vboot_common.c b/src/security/vboot/vboot_common.c index 215e209..87f382f 100644 --- a/src/security/vboot/vboot_common.c +++ b/src/security/vboot/vboot_common.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <boot_device.h> #include <console/cbmem_console.h> #include <reset.h> #include <security/vboot/misc.h> diff --git a/src/soc/nvidia/tegra124/spi.c b/src/soc/nvidia/tegra124/spi.c index adf0248..18ea626d 100644 --- a/src/soc/nvidia/tegra124/spi.c +++ b/src/soc/nvidia/tegra124/spi.c @@ -4,7 +4,6 @@ #include <arch/cache.h> #include <device/mmio.h> #include <assert.h> -#include <boot_device.h> #include <console/console.h> #include <delay.h> #include <soc/addressmap.h> diff --git a/src/soc/nvidia/tegra210/spi.c b/src/soc/nvidia/tegra210/spi.c index 8fde9c2..067d77e 100644 --- a/src/soc/nvidia/tegra210/spi.c +++ b/src/soc/nvidia/tegra210/spi.c @@ -4,7 +4,6 @@ #include <arch/cache.h> #include <device/mmio.h> #include <assert.h> -#include <boot_device.h> #include <console/console.h> #include <delay.h> #include <spi-generic.h>
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)