Attention is currently required from: Furquan Shaikh, Subrata Banik, Kyösti Mälkki, Patrick Rudolph.
Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50297 )
Change subject: soc/intel: Drop CID1 from GNVS
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/nvs.h:
https://review.coreboot.org/c/coreboot/+/50297/comment/38617acc_73830070
PS2, Line 23: unused_was_cid1
Removing these fields would affect the layout of the structure, and the comments would need to be up […]
But the structure is defined and used within coreboot, there's no 3rdparty dependency. so shall be safe to do so right?
But fail build as a fail-safe protection make some sense, what about a follow up commit to totally drop it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50297
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09ea756fb3743e33d1e221f0a0df3a6fdc3fc3ba
Gerrit-Change-Number: 50297
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 08 Feb 2021 02:52:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lance Zhao
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment