Change in coreboot[master]: util/sconfig: Emit array of PNP UART devices - coreboot-gerrit

24 May 2020


      Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31934 )
Change subject: util/sconfig: Emit array of PNP UART devices
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/31934/8/util/sconfig/main.c 
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/31934/8/util/sconfig/main.c@834 
PS8, Line 834: unsigned int
Maybe use uint16_t for IO ports?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31934
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9330bcd5545ec3f94c1c14ed4a639f1ef0548e43
Gerrit-Change-Number: 31934
Gerrit-PatchSet: 8
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 24 May 2020 09:27:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment