Change in coreboot[master]: SMBIOS: (Type 17) Add High Bandwidth Memory device type value
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35893 )
Change subject: SMBIOS: (Type 17) Add High Bandwidth Memory device type value ......................................................................
SMBIOS: (Type 17) Add High Bandwidth Memory device type value
Change-Id: Ia174e09bffdadeed4a18d443f75e2386d756e9bf Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/smbios.h 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35893/1
diff --git a/src/include/smbios.h b/src/include/smbios.h index 4247183..d7eff00 100644 --- a/src/include/smbios.h +++ b/src/include/smbios.h @@ -170,6 +170,8 @@ MEMORY_TYPE_LPDDR3 = 0x1d, MEMORY_TYPE_LPDDR4 = 0x1e, MEMORY_TYPE_LOGICAL_NON_VOLATILE_DEVICE = 0x1f, + MEMORY_TYPE_HBM = 0x20, + MEMORY_TYPE_HBM2 = 0x21, } smbios_memory_type;
typedef enum {
HAOUAS Elyes has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/35893 )
Change subject: SMBIOS (Type 17): Add HBM device type and DIE form factor value ......................................................................
SMBIOS (Type 17): Add HBM device type and DIE form factor value
Change-Id: Ia174e09bffdadeed4a18d443f75e2386d756e9bf Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/smbios.h 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35893/2
Hello Patrick Rudolph, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35893
to look at the new patch set (#3).
Change subject: SMBIOS (Type 17): Add HBM device type and DIE form factor value ......................................................................
SMBIOS (Type 17): Add HBM device type and DIE form factor value
Add High Bandwidth Memory, High Bandwidth Memory Generation 2 and new form factor value (Die).
Change-Id: Ia174e09bffdadeed4a18d443f75e2386d756e9bf Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/smbios.h 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35893/3
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35893 )
Change subject: SMBIOS (Type 17): Add HBM device type and DIE form factor value ......................................................................
Patch Set 3: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35893 )
Change subject: SMBIOS (Type 17): Add HBM device type and DIE form factor value ......................................................................
SMBIOS (Type 17): Add HBM device type and DIE form factor value
Add High Bandwidth Memory, High Bandwidth Memory Generation 2 and new form factor value (Die).
Change-Id: Ia174e09bffdadeed4a18d443f75e2386d756e9bf Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/35893 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/smbios.h 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/include/smbios.h b/src/include/smbios.h index 4247183..eb947dc 100644 --- a/src/include/smbios.h +++ b/src/include/smbios.h @@ -139,6 +139,7 @@ MEMORY_FORMFACTOR_SODIMM = 0x0d, MEMORY_FORMFACTOR_SRIMM = 0x0e, MEMORY_FORMFACTOR_FBDIMM = 0x0f, + MEMORY_FORMFACTOR_DIE = 0x10, } smbios_memory_form_factor;
typedef enum { @@ -170,6 +171,8 @@ MEMORY_TYPE_LPDDR3 = 0x1d, MEMORY_TYPE_LPDDR4 = 0x1e, MEMORY_TYPE_LOGICAL_NON_VOLATILE_DEVICE = 0x1f, + MEMORY_TYPE_HBM = 0x20, + MEMORY_TYPE_HBM2 = 0x21, } smbios_memory_type;
typedef enum {
-
HAOUAS Elyes (Code Review) -
Nico Huber (Code Review)