Attention is currently required from: Angel Pons, Eric Lai, Erik van den Bogaert, Frans Hendriks, Jeremy Soller, Jonathon Hall, Michael Niewöhner, Michał Żygowski, Nico Huber, Piotr Król, Sean Rhodes, Tim Crawford.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75888?usp=email )
Change subject: mb/{skl,kbl}: Use true/false keywords for non-array dt options
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Thank you all for your reviews. I adjusted the script that I use. Now it's much more generic and the result is reproducible, which doesn't need any intervention regarding tabs and spaces anymore.
As I explained in the commit message, arrays are left out and will be handled in a different patch. I guess we can get this in though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75888?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff063c37a093e597c6b73a583903ce5e4f698856
Gerrit-Change-Number: 75888
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Fri, 23 Jun 2023 03:04:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment