Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31103
Change subject: soc/intel/icelake: Enable RTC support ......................................................................
soc/intel/icelake: Enable RTC support
Turn on RTC support in coreboot stage.
BUG=N/A TEST=N/A
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: I77c8ba968f2c240673deed1a65b6568e4a26e5b6 --- M src/soc/intel/icelake/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/31103/1
diff --git a/src/soc/intel/icelake/Kconfig b/src/soc/intel/icelake/Kconfig index 34af339..258a91c 100644 --- a/src/soc/intel/icelake/Kconfig +++ b/src/soc/intel/icelake/Kconfig @@ -37,6 +37,7 @@ select POSTCAR_CONSOLE select POSTCAR_STAGE select REG_SCRIPT + select RTC select SMM_TSEG select SMP select SOC_AHCI_PORT_IMPLEMENTED_INVERT @@ -49,6 +50,7 @@ select SOC_INTEL_COMMON_BLOCK_CPU select SOC_INTEL_COMMON_BLOCK_CPU_MPINIT select SOC_INTEL_COMMON_BLOCK_GSPI_VERSION_2 + select SOC_INTEL_COMMON_BLOCK_RTC select SOC_INTEL_COMMON_BLOCK_HDA select SOC_INTEL_COMMON_BLOCK_SA select SOC_INTEL_COMMON_BLOCK_SMM
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31103 )
Change subject: soc/intel/icelake: Enable RTC support ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31103 )
Change subject: soc/intel/icelake: Enable RTC support ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31103/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31103/1//COMMIT_MSG@10 PS1, Line 10: : BUG=N/A : TEST=N/A Not required since it does not contain anything useful.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31103 )
Change subject: soc/intel/icelake: Enable RTC support ......................................................................
Patch Set 1: Code-Review+2
Hello Patrick Rudolph, Subrata Banik, Duncan Laurie, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31103
to look at the new patch set (#2).
Change subject: soc/intel/icelake: Enable RTC support ......................................................................
soc/intel/icelake: Enable RTC support
Turn on RTC support in coreboot stage.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: I77c8ba968f2c240673deed1a65b6568e4a26e5b6 --- M src/soc/intel/icelake/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/31103/2
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31103 )
Change subject: soc/intel/icelake: Enable RTC support ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31103/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31103/1//COMMIT_MSG@10 PS1, Line 10: : BUG=N/A : TEST=N/A
Not required since it does not contain anything useful.
Done
Hello Patrick Rudolph, Subrata Banik, Duncan Laurie, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31103
to look at the new patch set (#3).
Change subject: soc/intel/icelake: Enable RTC support ......................................................................
soc/intel/icelake: Enable RTC support
Turn on RTC support in coreboot stage.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: I77c8ba968f2c240673deed1a65b6568e4a26e5b6 --- M src/soc/intel/icelake/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/31103/3
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31103 )
Change subject: soc/intel/icelake: Enable RTC support ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31103/3/src/soc/intel/icelake/Kconfig File src/soc/intel/icelake/Kconfig:
https://review.coreboot.org/#/c/31103/3/src/soc/intel/icelake/Kconfig@40 PS3, Line 40: select RTC some comment here
https://review.coreboot.org/#/c/coreboot/+/31102/3/src/soc/intel/cannonlake/...
Lijian Zhao has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31103 )
Change subject: soc/intel/icelake: Enable RTC support ......................................................................
Abandoned
CB:31112 have the changes.
-
Duncan Laurie (Code Review) -
Furquan Shaikh (Code Review)
-
Lijian Zhao (Code Review)
-
Subrata Banik (Code Review)