Attention is currently required from: Arthur Heymans, Chen, Gang C, Christian Walter, David Hendricks, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Shuo Liu, TangYiwei, Tim Chu.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81316?usp=email )
Change subject: soc/intel/xeon_sp: Add GraniteRapids initial codes
......................................................................
Patch Set 20:
(1 comment)
File src/soc/intel/xeon_sp/chip_gen6.c:
https://review.coreboot.org/c/coreboot/+/81316/comment/f1d68edc_1f12039c :
PS18, Line 145: soc_create_fsp24_domains(dp, upstream, sr, DOMAIN_TYPE_IOAT, pci_segment_group);
Alternative would be: we split iio_domain_set_acpi_name between gen1 and gen6, for gen6, the 2nd cha […]
On gen1 there are multiple PCI domains of the same type on the same stack. It works on gen1. What's the problem here?
A good solution would be:
1. Add root UID into union xeon_domain_path on gen1
2. Use root UID to increment 2nd char of DOMAIN_TYPE
3. Update gen1 to use new root UID
4. Drop define DOMAIN_TYPE_UBX1, DOMAIN_TYPE_HQM1, DOMAIN_TYPE_CPM1
5. Use new iio_domain_set_acpi_name on gen6 as well
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81316?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3084e1b5abf25d8d9504bebeaed2a15b916ed56b
Gerrit-Change-Number: 81316
Gerrit-PatchSet: 20
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: TangYiwei
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Thu, 21 Mar 2024 06:44:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com
Gerrit-MessageType: comment