Attention is currently required from: Ravi kumar, Shelley Chen, Martin Roth, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49767 )
Change subject: sc7280: aop loading changes ......................................................................
Patch Set 32:
(26 comments)
File src/soc/qualcomm/sc7280/aop_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/0e8ee367_470593dc PS32, Line 11: bool aop_fw_entry; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/50b51526_ced2fc05 PS32, Line 11: bool aop_fw_entry; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/09744fb8_c63e1350 PS32, Line 13: struct prog aop_fw_prog = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/801a8a2f_de56d586 PS32, Line 13: struct prog aop_fw_prog = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/edfa291f_b502fb6b PS32, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/6ac0f82c_c336d859 PS32, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/32addc90_571a9581 PS32, Line 16: if (prog_locate(&aop_fw_prog)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/a9aeff15_933c1856 PS32, Line 16: if (prog_locate(&aop_fw_prog)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/9617fecc_fe0de01d PS32, Line 17: die("SOC image: AOP_FW not found"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/d6b25fd0_f118cbe0 PS32, Line 17: die("SOC image: AOP_FW not found"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/202b616e_55480759 PS32, Line 19: aop_fw_entry = selfload(&aop_fw_prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/6bf8946c_76a1409a PS32, Line 19: aop_fw_entry = selfload(&aop_fw_prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/da6f781c_2d63e40b PS32, Line 20: if (!aop_fw_entry) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/e04d93f8_daddddc9 PS32, Line 20: if (!aop_fw_entry) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/1c13d7b0_79747d7f PS32, Line 21: die("SOC image: AOP load failed"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/4fe4ee12_5134a2e9 PS32, Line 21: die("SOC image: AOP load failed"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/b4b51c9b_d9e6596a PS32, Line 23: clock_reset_aop(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/054fb45a_ccaaed6c PS32, Line 23: clock_reset_aop(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/82b51695_b5f50695 PS32, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/ed080bc8_84b79716 PS32, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/mmu.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/4e5d3ee7_fa9d763c PS32, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/a88b17ad_8c524b67 PS32, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/49ef1640_9e93e738 PS32, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/5e421435_ddc35031 PS32, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/3f8569f1_997bc8b7 PS32, Line 15: REGION_SIZE(dram_aop) / KiB); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117993): https://review.coreboot.org/c/coreboot/+/49767/comment/d4462607_9010edf7 PS32, Line 15: REGION_SIZE(dram_aop) / KiB); please, no spaces at the start of a line