Change in coreboot[master]: arch/x86/include/arch: Add smm_segs.h

[Name of user not set (Code Review)]

[e-mail] has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38520 )

Change subject: arch/x86/include/arch: Add smm_segs.h
......................................................................

arch/x86/include/arch: Add smm_segs.h

Contains the segment defines for the SMI handler.  Currently used
for the STM setup.

Change-Id: Ifd163a1687b7e6bd4345895b6349d716b8b3b5c2
Signed-off-by: Eugene D. Myers 
---
A src/arch/x86/include/arch/smm_segs.h
1 file changed, 22 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/38520/1

diff --git a/src/arch/x86/include/arch/smm_segs.h b/src/arch/x86/include/arch/smm_segs.h
new file mode 100644
index 0000000..0c72761
--- /dev/null
+++ b/src/arch/x86/include/arch/smm_segs.h
@@ -0,0 +1,22 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef SMM_SEGS_H
+#define SMM_SEGS_H
+
+#define SMM_CODE_SEG 0x08
+#define SMM_DATA_SEG 0x10
+#define SMM_CODE_SEG64 0x18
+
+#endif /* SMM_SEGS_H */
+

[Name of user not set (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38520

to look at the new patch set (#2).

Change subject: arch/x86/include/arch: Add smm_segs.h
......................................................................

arch/x86/include/arch: Add smm_segs.h

Contains the segment defines for the SMI handler.  Currently used
for the STM setup.

Change-Id: Ifd163a1687b7e6bd4345895b6349d716b8b3b5c2
Signed-off-by: Eugene D. Myers 
---
A src/arch/x86/include/arch/smm_segs.h
1 file changed, 21 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/38520/2

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38520 )

Change subject: arch/x86/include/arch: Add smm_segs.h
......................................................................

Patch Set 2:

Please make use of them in SMM code.

[Name of user not set (Code Review)]

[e-mail] has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38520 )

Change subject: arch/x86/include/arch: Add smm_segs.h
......................................................................

Patch Set 2:
> Patch Set 2:
>
> Please make use of them in SMM code.

[Name of user not set (Code Review)]

[e-mail] has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38520 )

Change subject: arch/x86/include/arch: Add smm_segs.h
......................................................................

Patch Set 2:
> Patch Set 2:
> > Patch Set 2:
> >
> > Please make use of them in SMM code.

These defines are used in setup_smm_descriptor (StmPlatformSmm.c) to initialize the segment selector values in the smm descriptor.  The smm descriptor is used by the STM to setup the environment for the SMI handler.

[Name of user not set (Code Review)]

Hello ron minnich, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38520

to look at the new patch set (#3).

Change subject: arch/x86/include/arch: Add smm_segs.h
......................................................................

arch/x86/include/arch: Add smm_segs.h

Contains the segment defines for the SMI handler.  Currently used
for the STM setup.

Change-Id: Ifd163a1687b7e6bd4345895b6349d716b8b3b5c2
Signed-off-by: Eugene D. Myers 
---
A src/arch/x86/include/arch/smm_segs.h
1 file changed, 22 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/38520/3

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38520 )

Change subject: arch/x86/include/arch: Add smm_segs.h
......................................................................

Patch Set 3: Code-Review-1

[Name of user not set (Code Review)]

[e-mail] has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38520 )

Change subject: arch/x86/include/arch: Add smm_segs.h
......................................................................

Patch Set 3:

Okay what do I need to get this resolved?

I created these defines so that in the code the reader would be able to see that the values being placed into the data structure (smm descriptor) are for smm descriptors.

Just let me know.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38520 )

Change subject: arch/x86/include/arch: Add smm_segs.h
......................................................................

Patch Set 3:
> Patch Set 3:
>
> Okay what do I need to get this resolved?
>
> I created these defines so that in the code the reader would be able to see that the values being placed into the data structure (smm descriptor) are for smm descriptors.
>
> Just let me know.

Since it's a pretty small change, maybe squash it into CB:33234 ?

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38520 )

Change subject: arch/x86/include/arch: Add smm_segs.h
......................................................................

Patch Set 3:

Please use the new defines as those in rom_segs.h and ram_segs.h.
For example cpu/x86/smm/smm_stub.S or cpu/x86/smm/smmhandler.S

[Name of user not set (Code Review)]

[e-mail] has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38520 )

Change subject: arch/x86/include/arch: Add smm_segs.h
......................................................................

Abandoned

decided to used rom_segs.h