Change in coreboot[master]: src/device/pci_rom.c: Show device IDs on oprom failure

[Felix Held (Code Review)]

Hello Raul Rangel,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/39586

to review the following change.

Change subject: src/device/pci_rom.c: Show device IDs on oprom failure
......................................................................

src/device/pci_rom.c: Show device IDs on oprom failure

On a device/option-rom ID mismatch, the option rom's IDs would get
shown twice instead of showing the actual device's IDs. This was
very confusing because the error showed matching IDs.

BUG=None
TEST=Shows mismatched IDs when option rom doesn't match the hardware

Change-Id: I5a06d6a7319aa653c8a5e32ec3c5afb651d83140
Signed-off-by: Martin Roth 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...
Reviewed-by: Raul E Rangel 
---
M src/device/pci_rom.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/39586/1

diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c
index 816255d..27f2d8d 100644
--- a/src/device/pci_rom.c
+++ b/src/device/pci_rom.c
@@ -98,7 +98,7 @@
        || dev->device != rom_data->device)
        && (vendev == mapped_vendev)) {
    	printk(BIOS_ERR, "ID mismatch: vendor ID %04x, "
-		       "device ID %04x\n", rom_data->vendor, rom_data->device);
+		       "device ID %04x\n", dev->vendor, dev->device);
    	return NULL;
    }

[Raul Rangel (Code Review)]

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39586 )

Change subject: src/device/pci_rom.c: Show device IDs on oprom failure
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39586 )

Change subject: src/device/pci_rom.c: Show device IDs on oprom failure
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39586 )

Change subject: src/device/pci_rom.c: Show device IDs on oprom failure
......................................................................

src/device/pci_rom.c: Show device IDs on oprom failure

On a device/option-rom ID mismatch, the option rom's IDs would get
shown twice instead of showing the actual device's IDs. This was
very confusing because the error showed matching IDs.

BUG=None
TEST=Shows mismatched IDs when option rom doesn't match the hardware

Change-Id: I5a06d6a7319aa653c8a5e32ec3c5afb651d83140
Signed-off-by: Martin Roth 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...
Reviewed-by: Raul E Rangel 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39586
Tested-by: build bot (Jenkins) 
Reviewed-by: Raul Rangel 
Reviewed-by: Angel Pons 
---
M src/device/pci_rom.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Raul Rangel: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c
index 816255d..27f2d8d 100644
--- a/src/device/pci_rom.c
+++ b/src/device/pci_rom.c
@@ -98,7 +98,7 @@
        || dev->device != rom_data->device)
        && (vendev == mapped_vendev)) {
    	printk(BIOS_ERR, "ID mismatch: vendor ID %04x, "
-		       "device ID %04x\n", rom_data->vendor, rom_data->device);
+		       "device ID %04x\n", dev->vendor, dev->device);
    	return NULL;
    }