Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40916 )
Change subject: soc/amd/picasso/include/soc/romstage: Add missing include ......................................................................
soc/amd/picasso/include/soc/romstage: Add missing include
We use `int` in this file.
BUG=b:147042464 TEST=Trembyle still builds
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I207b0f4820627fc7cfd7c4927b84048a115f4fb6 --- M src/soc/amd/picasso/include/soc/romstage.h 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/40916/1
diff --git a/src/soc/amd/picasso/include/soc/romstage.h b/src/soc/amd/picasso/include/soc/romstage.h index 5d21d08..9edbb063 100644 --- a/src/soc/amd/picasso/include/soc/romstage.h +++ b/src/soc/amd/picasso/include/soc/romstage.h @@ -4,6 +4,8 @@ #ifndef __PICASSO_ROMSTAGE_H__ #define __PICASSO_ROMSTAGE_H__
+#include <stdint.h> + void mainboard_romstage_entry_s3(int s3_resume);
#endif /* __PICASSO_ROMSTAGE_H__ */
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40916 )
Change subject: soc/amd/picasso/include/soc/romstage: Add missing include ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/40916 )
Change subject: soc/amd/picasso/include/soc/romstage: Add missing include ......................................................................
Removed Code-Review+2 by Furquan Shaikh furquan@google.com
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40916 )
Change subject: soc/amd/picasso/include/soc/romstage: Add missing include ......................................................................
Patch Set 1:
I'm confused by the motivation of this change. int is a type in c. No includes are needed as it exists on its own from the compiler.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40916 )
Change subject: soc/amd/picasso/include/soc/romstage: Add missing include ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40916/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40916/1//COMMIT_MSG@9 PS1, Line 9: We use `int` in this file. stdint.h doesn't really provide a definition for int?
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40916 )
Change subject: soc/amd/picasso/include/soc/romstage: Add missing include ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40916/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40916/1//COMMIT_MSG@9 PS1, Line 9: We use `int` in this file.
stdint. […]
I just came to the same conclusion a second ago. I split it off from one of the patches, but didn't really look into it. Oops!
Raul Rangel has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40916 )
Change subject: soc/amd/picasso/include/soc/romstage: Add missing include ......................................................................
Abandoned
Not needed
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)
-
Raul Rangel (Code Review)