Bernardo Perez Priego has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58235 )
Change subject: mb/intel/adlrvp: Remove EC region
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
We need EC region in order to boot the Windows SKU and for Chrome SKU as this path is bypass for on- […]
Hello Subrata, this was required to enable CSE RW region update. Having an EC region prevents us from calculating correct CSE RW offset since this is determined by adding RW region (obtained by HECI query) and ME region in FMAP.
With EC, offset is not proper and system CSE can not jump into RW, causing the system to get into reboot loop:
cse_lite: Number of partitions = 3
cse_lite: Current partition = RO
cse_lite: Next partition = RO
cse_lite: Flags = 0x3
cselite: RO version = 16.0.10.1372 (Status=0x0, Start=0x2000, End=0x19afff)
cse_lite: RW version = 16.0.10.1372 (Status=0x3, Star
cse_lite: Set Boot Partition Info Command (RW) – RW partition failure
HECI: Global Reset(Type:1) Command
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58235
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic76c29069beb510dd7620f340e0aab212668c3f3
Gerrit-Change-Number: 58235
Gerrit-PatchSet: 2
Gerrit-Owner: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: AndreX Andraos
andrex.andraos@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Mon, 25 Oct 2021 17:21:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment