HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29917 )
Change subject: src: Remove unused variables ......................................................................
Patch Set 13:
Any takers for remaining unused variable? src/drivers/intel/fsp1_1/fsp_util.c:89:6: error: variable 'fsp_base' set but not used [-Werror=unused-but-set-variable] src/northbridge/amd/amdmct/mct_ddr3/mct_d.c:1743:10: error: variable 'rank_count_dimm1' set but not used [-Werror=unused-but-set-variable] src/northbridge/amd/amdmct/mct_ddr3/mct_d.c:3810:34: error: variable 'DramHoleOffset' set but not used [-Werror=unused-but-set-variable] src/northbridge/amd/amdmct/mct/mctdqs_d.c:1193:6: error: variable 'value' set but not used [-Werror=unused-but-set-variable] src/northbridge/amd/pi/00630F01/northbridge.c:471:15: error: variable 'hest' set but not used [-Werror=unused-but-set-variable] src/northbridge/amd/pi/00630F01/northbridge.c:688:6: error: variable 'reset_memhole' set but not used [-Werror=unused-but-set-variable] src/northbridge/amd/pi/00660F01/northbridge.c:458:15: error: variable 'hest' set but not used [-Werror=unused-but-set-variable] src/northbridge/amd/pi/00660F01/northbridge.c:683:6: error: variable 'reset_memhole' set but not used [-Werror=unused-but-set-variable] src/northbridge/intel/nehalem/raminit.c:3741:14: error: variable 'tmp8' set but not used [-Werror=unused-but-set-variable] src/northbridge/intel/nehalem/raminit.c:3742:15: error: variable 'tmp16' set but not used [-Werror=unused-but-set-variable] src/northbridge/intel/nehalem/raminit.c:3743:15: error: variable 'tmp32' set but not used [-Werror=unused-but-set-variable] src/northbridge/intel/pineview/raminit.c:1833:15: error: variable 'strobedata' set but not used [-Werror=unused-but-set-variable] src/northbridge/intel/sandybridge/raminit_common.c:2628:19: error: variable 'tmp' set but not used [-Werror=unused-but-set-variable] src/northbridge/intel/sandybridge/raminit_common.c:2676:19: error: variable 'tmp' set but not used [-Werror=unused-but-set-variable] src/northbridge/intel/x4x/raminit_ddr23.c:1320:15: error: variable 'rubbish' set but not used [-Werror=unused-but-set-variable] src/soc/mediatek/mt8173/i2c.c:113:26: error: variable 'regs' set but not used [-Werror=unused-but-set-variable] src/vendorcode/amd/agesa/f12/Legacy/Proc/agesaCallouts.c:103:16: error: variable 'Status' set but not used [-Werror=unused-but-set-variable] src/vendorcode/amd/agesa/f14/Legacy/Proc/agesaCallouts.c:107:16: error: variable 'Status' set but not used [-Werror=unused-but-set-variable] src/vendorcode/amd/agesa/f15tn/Legacy/Proc/agesaCallouts.c:103:16: error: variable 'Status' set but not used [-Werror=unused-but-set-variable] src/vendorcode/amd/agesa/f16kb/Legacy/Proc/agesaCallouts.c:104:16: error: variable 'Status' set but not used [-Werror=unused-but-set-variable]
-
HAOUAS Elyes (Code Review)