Attention is currently required from: Subrata Banik.
Paul Menzel has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86143?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/fatcat: Move FP from GSPI0A to GSPI0
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Patchset:
PS1:
Feel free to ignore and mark as resolved.
Commit Message:
https://review.coreboot.org/c/coreboot/+/86143/comment/87ef7deb_79cb44e2?usp... :
PS1, Line 9: FP
Spell it out in the beginning?
https://review.coreboot.org/c/coreboot/+/86143/comment/6f60f44b_6362b625?usp... :
PS1, Line 10: hardware design
Append schematic names.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86143?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3996f1a054204689ad733c650b6f71f1482c0b22
Gerrit-Change-Number: 86143
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Tue, 28 Jan 2025 09:10:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes