Attention is currently required from: Jakub Czapiga, Tim Wawrzynczak, Ivy Jian, Lean Sheng Tan.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63628 )
Change subject: lib: Treat dimm addr_map 0 as not exist
......................................................................
Patch Set 5:
(1 comment)
File tests/lib/spd_cache-test.c:
https://review.coreboot.org/c/coreboot/+/63628/comment/a6dc25c6_04e9b5db
PS3, Line 143:
Can you add test case with . […]
SG! Will do.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63628
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ada0109eb0805174cb85d4ce373e2a3ab7dbcac
Gerrit-Change-Number: 63628
Gerrit-PatchSet: 5
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Thu, 14 Apr 2022 10:48:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Gerrit-MessageType: comment