Change in coreboot[master]: [WIP] src/superio/smsc: Add support for the SCH5555 - coreboot-gerrit

6 Jun 2021


      Attention is currently required from: Máté Kukri (mkukri), Michael Niewöhner, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55250 )
Change subject: [WIP] src/superio/smsc: Add support for the SCH5555
......................................................................
Patch Set 3:
(1 comment)
File src/superio/smsc/sch5555/sch5555.h:
https://review.coreboot.org/c/coreboot/+/55250/comment/018d1b93_b24e49c0 
PS1, Line 51: #define EMI_IOBASE	0xa00
            : #define RUNTIME_IOBASE	0xa40
...
My main concern is that mainboard code needs to enable LPC forwarding on these addresses. […]
Oh, another thing: I would prefix the macros in chip.h with `SCH5555_` to namespace them.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55250
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9323198f1139cd0c3dd37f977ae7693b721654f4
Gerrit-Change-Number: 55250
Gerrit-PatchSet: 3
Gerrit-Owner: Máté Kukri (mkukri) kukri.mate@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Michael Niewöhner foss@mniewoehner.de
Gerrit-Attention: Máté Kukri (mkukri) kukri.mate@gmail.com
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 06 Jun 2021 15:58:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Máté Kukri (mkukri) kukri.mate@gmail.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment