Change in coreboot[master]: soc/intel/alderlake: set power limits dynamically for thermal

[Sumeet R Pawnikar (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Sumeet R Pawnikar, Patrick Rudolph, Karthik Ramasubramanian.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57035 )

Change subject: soc/intel/alderlake: set power limits dynamically for thermal
......................................................................

Patch Set 9:

(17 comments)

Patchset:

PS2:
> submitted another CL https://review.coreboot. […]

ACK

File src/soc/intel/alderlake/systemagent.c:

https://review.coreboot.org/c/coreboot/+/57035/comment/cb342410_55aebcc8 
PS1, Line 51: u8 get_cpu_tdp(void)
> Ack

ACK

https://review.coreboot.org/c/coreboot/+/57035/comment/61943ec6_ea00aba8 
PS1, Line 53: msr_t msr = rdmsr(MSR_PLATFORM_INFO);
> Done

ACK

https://review.coreboot.org/c/coreboot/+/57035/comment/e8fff278_b8729ebb 
PS1, Line 107: 			soc_config = &config->power_limits_config[ADL_P_POWER_LIMITS_682_28W_CORE];
> line over 96 characters

Please fix.

https://review.coreboot.org/c/coreboot/+/57035/comment/ba0f7e9f_0b57ba56 
PS1, Line 109: 			soc_config = &config->power_limits_config[ADL_P_POWER_LIMITS_682_45W_CORE];
> line over 96 characters

Please fix.

File src/soc/intel/alderlake/systemagent.c:

https://review.coreboot.org/c/coreboot/+/57035/comment/f59d9c86_f47721c1 
PS2, Line 89: 			soc_config = &config->power_limits_config[ADL_P_POWER_LIMITS_682_28W_CORE];
> line over 96 characters

Please fix.

https://review.coreboot.org/c/coreboot/+/57035/comment/cba8f0d0_834355f0 
PS2, Line 91: 			soc_config = &config->power_limits_config[ADL_P_POWER_LIMITS_682_45W_CORE];
> line over 96 characters

Please fix.

File src/soc/intel/alderlake/systemagent.c:

https://review.coreboot.org/c/coreboot/+/57035/comment/bd98b86f_51cef882 
PS3, Line 76: tdp = get_cpu_tdp();
> I'm just thinking loud, what if tomorrow there is different TDP SKUs under ADL_P_ID_5/7, in that cas […]

Done

File src/soc/intel/alderlake/systemagent.c:

https://review.coreboot.org/c/coreboot/+/57035/comment/a3c31c49_3139a4db 
PS4, Line 89: 			soc_config =
> trailing whitespace

Please fix.

https://review.coreboot.org/c/coreboot/+/57035/comment/6408e3e9_96bdc173 
PS4, Line 90:                   		&config->power_limits_config[ADL_P_POWER_LIMITS_682_28W_CORE];
> please, no spaces at the start of a line

Please fix.

https://review.coreboot.org/c/coreboot/+/57035/comment/f248a143_9a717060 
PS4, Line 90:                   		&config->power_limits_config[ADL_P_POWER_LIMITS_682_28W_CORE];
> code indent should use tabs where possible

Please fix.

https://review.coreboot.org/c/coreboot/+/57035/comment/1eb3b9be_a10a2ca3 
PS4, Line 90:                   		&config->power_limits_config[ADL_P_POWER_LIMITS_682_28W_CORE];
> please, no space before tabs

Please fix.

https://review.coreboot.org/c/coreboot/+/57035/comment/f6d141c5_65efd7ac 
PS4, Line 92: 			soc_config =
> trailing whitespace

Please fix.

https://review.coreboot.org/c/coreboot/+/57035/comment/cb31b2f6_24aee431 
PS4, Line 93:                   		&config->power_limits_config[ADL_P_POWER_LIMITS_682_45W_CORE];
> please, no spaces at the start of a line

Please fix.

https://review.coreboot.org/c/coreboot/+/57035/comment/15920bb5_7d280fea 
PS4, Line 93:                   		&config->power_limits_config[ADL_P_POWER_LIMITS_682_45W_CORE];
> code indent should use tabs where possible

Please fix.

https://review.coreboot.org/c/coreboot/+/57035/comment/2feeb442_7ac6bc63 
PS4, Line 93:                   		&config->power_limits_config[ADL_P_POWER_LIMITS_682_45W_CORE];
> please, no space before tabs

Please fix.

File src/soc/intel/alderlake/systemagent.c:

https://review.coreboot.org/c/coreboot/+/57035/comment/6f9d84c2_40845301 
PS8, Line 90: ADL
> ERROR

Done