Attention is currently required from: Paul Menzel, Zhi7 Li, Karthik Ramasubramanian.
Weimin Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56804 )
Change subject: mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR
......................................................................
Patch Set 11: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56804/comment/9b9a0fcc_3a929465
PS11, Line 9: commit df520855 (soc/intel/jsl: Add disable_external_bypass_vr config)
Refer to
File src/mainboard/google/dedede/variants/sasukette/ramstage.c:
https://review.coreboot.org/c/coreboot/+/56804/comment/244fb1a7_49a6be52
PS11, Line 33: variant_
delete
https://review.coreboot.org/c/coreboot/+/56804/comment/4a998568_82691071
PS11, Line 44: variant_
delete
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56804
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15ab30f14df9dc02157009091aa8398e2fa75188
Gerrit-Change-Number: 56804
Gerrit-PatchSet: 11
Gerrit-Owner: Zhi7 Li
lizhi7@huaqin.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Rui Huang
huangrui@huaqin.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Zhi7 Li
lizhi7@huaqin.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 17 Aug 2021 12:25:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment