Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34446 )
Change subject: 3rdparty/blobs: Add Facebook FBG1701 VBT binary ......................................................................
3rdparty/blobs: Add Facebook FBG1701 VBT binary
Upgrade to 3rdparty/blobs with VBT binary.
BUG=N/A TEST=booting Facebook FBG1701
Change-Id: If327e4e071df61b02fcec45213c2b700320ef269 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M 3rdparty/blobs 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/34446/1
diff --git a/3rdparty/blobs b/3rdparty/blobs index d7600dd..94a2f7e 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit d7600dd8718a076f0f9a89e53968b484254624dc +Subproject commit 94a2f7e44e23e7bfcf579432e7ac0f51746e3acf
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34446 )
Change subject: 3rdparty/blobs: Add Facebook FBG1701 VBT binary ......................................................................
Patch Set 1:
The VBT goes into the mainboard directory as data.vbt See src/mainboard/lenovo/t420 for example.
It was decided that VBT is not a BLOB, but binary board specific configuration data.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34446
to look at the new patch set (#2).
Change subject: mainboard/facebook/fbg1701: Add VBT binary ......................................................................
mainboard/facebook/fbg1701: Add VBT binary
Add VBT 8.0.1038 binary.
Panel #10 is modified to support the 1200x1920 panel. This panel is configured as default.
LCD and HDMI are working fine.
BUG=N/A TEST=booting Facebook FBG1701
Change-Id: If327e4e071df61b02fcec45213c2b700320ef269 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/Kconfig A src/mainboard/facebook/fbg1701/data.vbt 2 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/34446/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34446
to look at the new patch set (#3).
Change subject: mainboard/facebook/fbg1701: Add VBT binary ......................................................................
mainboard/facebook/fbg1701: Add VBT binary
Add VBT 8.0.1038 binary.
Panel #10 is modified to support the 1200x1920 LCD panel. This panel is configured as default.
LCD and HDMI are working fine.
BUG=N/A TEST=booting Facebook FBG1701
Change-Id: If327e4e071df61b02fcec45213c2b700320ef269 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/Kconfig A src/mainboard/facebook/fbg1701/data.vbt 2 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/34446/3
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34446 )
Change subject: mainboard/facebook/fbg1701: Add VBT binary ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34446/3/src/mainboard/facebook/fbg1... File src/mainboard/facebook/fbg1701/Kconfig:
https://review.coreboot.org/c/coreboot/+/34446/3/src/mainboard/facebook/fbg1... PS3, Line 30: select INTEL_GMA_ADD_VBT try "select INTEL_GMA_HAVE_VBT" then you don't have to specify the VBT path.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34446 )
Change subject: mainboard/facebook/fbg1701: Add VBT binary ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34446/3/src/mainboard/facebook/fbg1... File src/mainboard/facebook/fbg1701/Kconfig:
https://review.coreboot.org/c/coreboot/+/34446/3/src/mainboard/facebook/fbg1... PS3, Line 30: select INTEL_GMA_ADD_VBT
try "select INTEL_GMA_HAVE_VBT" then you don't have to specify the VBT path.
Does not work on fsp1.1 using RUN_FSP_GOP also. Function load_vbt is not available. This function (file vbt.c) will be included through src/drivers/intel/fsp1_1/Makefile.inc when INTEL_GMA_ADD_VBT is enabled only.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34446 )
Change subject: mainboard/facebook/fbg1701: Add VBT binary ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34446/3/src/mainboard/facebook/fbg1... File src/mainboard/facebook/fbg1701/Kconfig:
https://review.coreboot.org/c/coreboot/+/34446/3/src/mainboard/facebook/fbg1... PS3, Line 30: select INTEL_GMA_ADD_VBT
Does not work on fsp1.1 using RUN_FSP_GOP also. Function load_vbt is not available. […]
What does not work? INTEL_GMA_HAVE_VBT is just a Kconfig option to automatically set a path and default INTEL_GMA_ADD_VBT to y.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34446 )
Change subject: mainboard/facebook/fbg1701: Add VBT binary ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34446/3/src/mainboard/facebook/fbg1... File src/mainboard/facebook/fbg1701/Kconfig:
https://review.coreboot.org/c/coreboot/+/34446/3/src/mainboard/facebook/fbg1... PS3, Line 30: select INTEL_GMA_ADD_VBT
What does not work? INTEL_GMA_HAVE_VBT is just a Kconfig option to automatically set a path and defa […]
Did a retry and now it's working fine.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34446
to look at the new patch set (#4).
Change subject: mainboard/facebook/fbg1701: Add VBT binary ......................................................................
mainboard/facebook/fbg1701: Add VBT binary
Add VBT 8.0.1038 binary.
Panel #10 is modified to support the 1200x1920 LCD panel. This panel is configured as default.
LCD and HDMI are working fine.
BUG=N/A TEST=booting Facebook FBG1701
Change-Id: If327e4e071df61b02fcec45213c2b700320ef269 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/Kconfig A src/mainboard/facebook/fbg1701/data.vbt 2 files changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/34446/4
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34446 )
Change subject: mainboard/facebook/fbg1701: Add VBT binary ......................................................................
Patch Set 4: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34446 )
Change subject: mainboard/facebook/fbg1701: Add VBT binary ......................................................................
Patch Set 4: Code-Review+2
Patrick Rudolph has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34446 )
Change subject: mainboard/facebook/fbg1701: Add VBT binary ......................................................................
mainboard/facebook/fbg1701: Add VBT binary
Add VBT 8.0.1038 binary.
Panel #10 is modified to support the 1200x1920 LCD panel. This panel is configured as default.
LCD and HDMI are working fine.
BUG=N/A TEST=booting Facebook FBG1701
Change-Id: If327e4e071df61b02fcec45213c2b700320ef269 Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34446 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/facebook/fbg1701/Kconfig A src/mainboard/facebook/fbg1701/data.vbt 2 files changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved Arthur Heymans: Looks good to me, approved
diff --git a/src/mainboard/facebook/fbg1701/Kconfig b/src/mainboard/facebook/fbg1701/Kconfig index 95d8f6c..177393e 100644 --- a/src/mainboard/facebook/fbg1701/Kconfig +++ b/src/mainboard/facebook/fbg1701/Kconfig @@ -27,6 +27,7 @@ select HAVE_FSP_BIN select CACHE_MRC_SETTINGS select DISABLE_HPET + select INTEL_GMA_HAVE_VBT select GENERIC_SPD_BIN
choice diff --git a/src/mainboard/facebook/fbg1701/data.vbt b/src/mainboard/facebook/fbg1701/data.vbt new file mode 100644 index 0000000..39eba56 --- /dev/null +++ b/src/mainboard/facebook/fbg1701/data.vbt Binary files differ
-
Arthur Heymans (Code Review) -
Frans Hendriks (Code Review)
-
Patrick Rudolph (Code Review)