Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27531 )
Change subject: mb/*/*: Use libgfxinit on sandy and ivy bridge boards
......................................................................
Patch Set 10:
$ for k in $(git grep -l SANDYBRIDGE_IVYBRIDGE_LVDS src/mainboard/); do grep -q GFX_GMA_INTERNAL_IS_LVDS $k || echo $k; done
src/mainboard/compulab/intense_pc/Kconfig
src/mainboard/google/stout/Kconfig
src/mainboard/lenovo/t520/Kconfig
intense_pc does not have LVDS so that's weird and l520 likely
doesn't work due to improper panel timing and backlight setting in
the devicetree.
Should increase the font size. I read l520 instead of t520...
Likely corrected subconsciously because you didn't touch T520 here?
Odd anyway, is somebody running it w/o internal panel?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/27531
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41ad1ce06d9afcc99941affa232fa76ffa6631fb
Gerrit-Change-Number: 27531
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Evgeny Zinoviev
me@ch1p.com
Gerrit-Comment-Date: Fri, 11 Jan 2019 15:53:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment