Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34684 )
Change subject: lib/spd_bin: Fix bug with rank parsing for DDR4
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34684/1/src/lib/spd_bin.c
File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/34684/1/src/lib/spd_bin.c@a76
PS1, Line 76:
However it should be ranks = spd_ranks[(spd[12] >> 3) & 7] + 1; because in spec 00 is 1 and 01 is […]
I would suggest making #define values for SPD bytes have a 'DDR_' prefix, for example:
#define DDR3_SPD_ORGANIZATION 7
[...]
#define DDR4_SPD_ORGANIZATION 12
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34684
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3184c5a7fd4b5ae5882914e62d1cb0c28bb881e7
Gerrit-Change-Number: 34684
Gerrit-PatchSet: 1
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 29 Aug 2019 10:56:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andrey Petrov
anpetrov@fb.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment