YanRu Chen has posted comments on this change. ( https://review.coreboot.org/28484 )
Change subject: rammus: add SPD mapping for rammus and shyvana support. ......................................................................
Patch Set 1:
(1 comment)
The memory strapping table of rammus project start from 0b0001 to 0b0100. We don't have table for 0b000, so we copy 0b0001 setting to 0b0000 to follow your non empty requirement.
https://review.coreboot.org/#/c/28484/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/rammus/Makefile.inc:
https://review.coreboot.org/#/c/28484/1/src/mainboard/google/poppy/variants/... PS1, Line 1: samsung_dimm_K4E8E324EB-EGCF
Memory ID 0 and 1 are using the same memory?
The memory strapping table of rammus project start from 0b0001 to 0b0100. We don't have table for 0b000, so we copy 0b0001 setting to 0b0000 to follow your non empty requirement.
-
YanRu Chen (Code Review)