Change in ...coreboot[master]: Signed-off-by: Eric Lai <ericr_lai@compal.corp-partner.google.com> Ch...
EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32264
Change subject: Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I77d4aa39cee875dd1b6ab8ffa89454c2e5c13ab5 ......................................................................
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I77d4aa39cee875dd1b6ab8ffa89454c2e5c13ab5 --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb 2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/32264/1
diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb index 28644d1..7d668fe 100644 --- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -68,6 +68,19 @@ register "stop_off_delay_ms" = "5" device i2c 49 on end end + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "generic.reset_delay_ms" = "30" + register "generic.reset_off_delay_ms" = "3" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 5d on end + end end # I2C #1 device pci 15.2 on chip drivers/generic/gpio_keys diff --git a/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb b/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb index 9b772c2..caa80a5 100644 --- a/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb @@ -53,6 +53,19 @@ register "stop_off_delay_ms" = "5" device i2c 49 on end end + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "generic.reset_delay_ms" = "30" + register "generic.reset_off_delay_ms" = "3" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 5d on end + end end # I2C #1 device pci 15.2 on chip drivers/generic/gpio_keys
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32264 )
Change subject: Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I77d4aa39cee875dd1b6ab8ffa89454c2e5c13ab5 ......................................................................
Patch Set 1:
(24 comments)
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/hatch/overridetree.cb:
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 71: chip drivers/i2c/hid trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 72: register "generic.hid" = ""GDIX0000"" trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 73: register "generic.desc" = ""Goodix Touchscreen"" trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 74: register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 75: register "generic.probed" = "1" trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 76: register "generic.reset_gpio" = trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 77: "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 78: register "generic.reset_delay_ms" = "30" trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 79: register "generic.reset_off_delay_ms" = "3" trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 80: register "generic.has_power_resource" = "1" trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 81: register "hid_desc_reg_offset" = "0x01" trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 82: device i2c 5d on end trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb:
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 56: chip drivers/i2c/hid trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 57: register "generic.hid" = ""GDIX0000"" trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 58: register "generic.desc" = ""Goodix Touchscreen"" trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 59: register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 60: register "generic.probed" = "1" trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 61: register "generic.reset_gpio" = trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 62: "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 63: register "generic.reset_delay_ms" = "30" trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 64: register "generic.reset_off_delay_ms" = "3" trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 65: register "generic.has_power_resource" = "1" trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 66: register "hid_desc_reg_offset" = "0x01" trailing whitespace
https://review.coreboot.org/#/c/32264/1/src/mainboard/google/hatch/variants/... PS1, Line 67: device i2c 5d on end trailing whitespace
EricR Lai has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32264 )
Change subject: Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I77d4aa39cee875dd1b6ab8ffa89454c2e5c13ab5 ......................................................................
Abandoned
oops error
-
build bot (Jenkins) (Code Review) -
EricR Lai (Code Review)