Yang Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86640?usp=email )
Change subject: mb/google/geralt: Tuning CSOT_PNA957QT1_1 panel VSP/VSN voltage for Ciri ......................................................................
mb/google/geralt: Tuning CSOT_PNA957QT1_1 panel VSP/VSN voltage for Ciri
The system default VSP/VSN voltage for Ciri is +-5.7V. According to the CSOT panel vendor's requirement, VSP/VSN for the CSOT_PNA957QT1_1 panel needs to be adjusted to +-6V. So modify the relevant register values accordingly.
BUG=b:399728328 TEST=Boot to firmware screen BRANCH=Geralt
Change-Id: I1b69303317f5ef47818f4a6a0c851bf650285e51 Signed-off-by: Yang Wu wuyang5@huaqin.corp-partner.google.com --- M src/mainboard/google/geralt/panel_ciri.c 1 file changed, 16 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/86640/1
diff --git a/src/mainboard/google/geralt/panel_ciri.c b/src/mainboard/google/geralt/panel_ciri.c index 4c21e90..e746e9c 100644 --- a/src/mainboard/google/geralt/panel_ciri.c +++ b/src/mainboard/google/geralt/panel_ciri.c @@ -8,11 +8,11 @@
#define PMIC_TPS65132_I2C I2C3
-static void power_on_mipi_himax_83102j(void) +static void power_on_mipi_himax_83102j(uint8_t val) { const struct tps65132s_reg_setting reg_settings[] = { - { PMIC_TPS65132_VPOS, 0x11, 0x1f }, - { PMIC_TPS65132_VNEG, 0x11, 0x1f }, + { PMIC_TPS65132_VPOS, val, 0x1f }, + { PMIC_TPS65132_VNEG, val, 0x1f }, { PMIC_TPS65132_DLYX, 0x55, 0xff }, { PMIC_TPS65132_ASSDD, 0x5b, 0xff }, }; @@ -27,10 +27,20 @@ power_on_mipi_panel(&cfg); }
+static void power_on_mipi_himax_83102j_default(void) +{ + power_on_mipi_himax_83102j(0x11); +} + +static void power_on_mipi_himax_83102j_csot(void) +{ + power_on_mipi_himax_83102j(0x14); +} + static struct panel_description ciri_panels[] = { [17] = { .name = "BOE_NV110WUM_L60", - .power_on = power_on_mipi_himax_83102j, + .power_on = power_on_mipi_himax_83102j_default, .configure_backlight = configure_mipi_pwm_backlight, .orientation = LB_FB_ORIENTATION_LEFT_UP, .disp_path = DISP_PATH_MIPI, @@ -39,7 +49,7 @@
[34] = { .name = "IVO_T109NW41", - .power_on = power_on_mipi_himax_83102j, + .power_on = power_on_mipi_himax_83102j_default, .configure_backlight = configure_mipi_pwm_backlight, .orientation = LB_FB_ORIENTATION_LEFT_UP, .disp_path = DISP_PATH_MIPI, @@ -48,7 +58,7 @@
[51] = { .name = "CSOT_PNA957QT1_1", - .power_on = power_on_mipi_himax_83102j, + .power_on = power_on_mipi_himax_83102j_csot, .configure_backlight = configure_mipi_pwm_backlight, .orientation = LB_FB_ORIENTATION_LEFT_UP, .disp_path = DISP_PATH_MIPI,