Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60553 )
Change subject: soc/intel: Remove unused <string.h>
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS3:
Hmm, that is a lot of files to verify at one time that shouldn't have string.h included...
easy to find using:
diff <(git grep -l '#include <string.h>' -- src/) <(git grep -l 'STRINGIFY|memcpy(|memmove(|memset(|memcmp(|memchr(|strdup(|strconcat(|strnlen(|strlen(|strchr(|strncpy(|strcpy(|strcmp(|strncmp(|strspn(|strcspn(|strstr(|strtok_r(|strtok(|atol(|strrchr(|skip_atoi(|vsnprintf(|snprintf(' -- src/)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60553
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae90ff482f534d8de2a519619c20a019d054e700
Gerrit-Change-Number: 60553
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 03 Jan 2022 15:20:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment