Change in coreboot[master]: soc/mediatek: dsi: Correct bits_per_pixel for MIPI_DSI_FMT_RGB666

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38845 )

Change subject: soc/mediatek: dsi: Correct bits_per_pixel for MIPI_DSI_FMT_RGB666
......................................................................

soc/mediatek: dsi: Correct bits_per_pixel for MIPI_DSI_FMT_RGB666

The number of bits per pixel for MIPI_DSI_FMT_RGB666 should be 24
instead of 18.

BRANCH=none
BUG=none
TEST=none

Change-Id: I9574502b2dec4b5a042df3886922ddd8c755da1a
Signed-off-by: Yu-Ping Wu 
---
M src/soc/mediatek/common/dsi.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/38845/1

diff --git a/src/soc/mediatek/common/dsi.c b/src/soc/mediatek/common/dsi.c
index 238b1eb..3efcf16 100644
--- a/src/soc/mediatek/common/dsi.c
+++ b/src/soc/mediatek/common/dsi.c
@@ -28,9 +28,9 @@
    switch (format) {
    case MIPI_DSI_FMT_RGB565:
    	return 16;
-	case MIPI_DSI_FMT_RGB666:
    case MIPI_DSI_FMT_RGB666_PACKED:
    	return 18;
+	case MIPI_DSI_FMT_RGB666:
    case MIPI_DSI_FMT_RGB888:
    	return 24;
    }

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38845 )

Change subject: soc/mediatek: dsi: Correct bits_per_pixel for MIPI_DSI_FMT_RGB666
......................................................................

Patch Set 1: Code-Review+1

I'd also like jitao to confirm.

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38845 )

Change subject: soc/mediatek: dsi: Correct bits_per_pixel for MIPI_DSI_FMT_RGB666
......................................................................

Patch Set 1: Code-Review+1

[Jitao Shi (Code Review)]

Jitao Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38845 )

Change subject: soc/mediatek: dsi: Correct bits_per_pixel for MIPI_DSI_FMT_RGB666
......................................................................

Patch Set 1: Code-Review+1

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38845 )

Change subject: soc/mediatek: dsi: Correct bits_per_pixel for MIPI_DSI_FMT_RGB666
......................................................................

Patch Set 1: Code-Review+2

+2 since MTK confirmed it's the proper value

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38845 )

Change subject: soc/mediatek: dsi: Correct bits_per_pixel for MIPI_DSI_FMT_RGB666
......................................................................

soc/mediatek: dsi: Correct bits_per_pixel for MIPI_DSI_FMT_RGB666

The number of bits per pixel for MIPI_DSI_FMT_RGB666 should be 24
instead of 18.

BRANCH=none
BUG=none
TEST=none

Change-Id: I9574502b2dec4b5a042df3886922ddd8c755da1a
Signed-off-by: Yu-Ping Wu 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38845
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Jitao Shi 
Reviewed-by: Hung-Te Lin 
---
M src/soc/mediatek/common/dsi.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Hung-Te Lin: Looks good to me, approved
  Jitao Shi: Looks good to me, but someone else must approve

diff --git a/src/soc/mediatek/common/dsi.c b/src/soc/mediatek/common/dsi.c
index be99fe8..03e177e 100644
--- a/src/soc/mediatek/common/dsi.c
+++ b/src/soc/mediatek/common/dsi.c
@@ -28,9 +28,9 @@
    switch (format) {
    case MIPI_DSI_FMT_RGB565:
    	return 16;
-	case MIPI_DSI_FMT_RGB666:
    case MIPI_DSI_FMT_RGB666_PACKED:
    	return 18;
+	case MIPI_DSI_FMT_RGB666:
    case MIPI_DSI_FMT_RGB888:
    	return 24;
    }

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38845 )

Change subject: soc/mediatek: dsi: Correct bits_per_pixel for MIPI_DSI_FMT_RGB666
......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3
Emulation targets:
EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/643
EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/642
EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/641

Please note: This test is under development and might not be accurate at all!