Attention is currently required from: Jérémy Compostella.
Hello Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74205
to look at the new patch set (#3).
Change subject: soc/intel/cmn/cse: Fix unnecessary End-Of-Post cases ......................................................................
soc/intel/cmn/cse: Fix unnecessary End-Of-Post cases
This patch fixes commit e7a1204f26fe ("soc/intel/cmn/cse: Handle EOP completion asynchronously").
Following the logic of `cse_send_eop()', there are two cases for which End-Of-Post should not be performed: 1. CSE lite is in "soft temp disable" state and vboot is in recovery mode 2. CSE is in "soft temp disable" state
This patch ensures that these two cases operate as expected. Even if the "Esc-Refresh PowerButton" is used to enter recovery which lead to a call of `do_send_end_of_post()' with CSE enabled (`is_cse_enable()' returns true).
BUG:b/276927816 BRANCH=firmware-brya-14505.B TEST=Enter recovery using "Esc-Refresh PowerButton" on brya/skolas
Change-Id: Id2d23df668ab698213e8b1af652ef9b90ccad046 Signed-off-by: Jeremy Compostella jeremy.compostella@intel.com --- M src/soc/intel/common/block/cse/cse_eop.c 1 file changed, 38 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/74205/3