Attention is currently required from: YH Lin, Paul Menzel, Zhuohao Lee, Raihow Shi, Felix Held.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63544 )
Change subject: mb/google/brask/variants/moli: add delay time to rtd3-cold
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63544/comment/47fdcb5a_5f39774b
PS1, Line 9: which will turn
: off the eMMC controller (a true D3cold state) during the RTD3 sequence.
The reason is both primus and moli use BH799BB, so I follow this CL: https://review.coreboot. […]
The reason is that the rise and fall times of each signal may differ by board, and so those board-specific delays must be taken into account when power sequencing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63544
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idecb1c89655c9b8b720c3c65efc77e06e6a8b300
Gerrit-Change-Number: 63544
Gerrit-PatchSet: 6
Gerrit-Owner: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 12 Apr 2022 19:04:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-MessageType: comment