Change in coreboot[master]: mb/google/octopus/variants/fleex: Remove gpio NC setting for enabling...
Frank Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34364 )
Change subject: mb/google/octopus/variants/fleex: Remove gpio NC setting for enabling I2C0 ......................................................................
mb/google/octopus/variants/fleex: Remove gpio NC setting for enabling I2C0
Enable I2C0 in fleex then verify EMR function successfully
BUG=b:135968368 BRANCH=octopus TEST=EMR function working normally with I2C0 in Grob360S.
Change-Id: I784ff32418bc839bcec14fbfd7236f708828690e Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com --- M src/mainboard/google/octopus/variants/fleex/gpio.c 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/34364/1
diff --git a/src/mainboard/google/octopus/variants/fleex/gpio.c b/src/mainboard/google/octopus/variants/fleex/gpio.c index d2d0d64..a1e02d2 100644 --- a/src/mainboard/google/octopus/variants/fleex/gpio.c +++ b/src/mainboard/google/octopus/variants/fleex/gpio.c @@ -21,8 +21,6 @@
static const struct pad_config default_override_table[] = {
- PAD_NC(GPIO_50, UP_20K), - PAD_NC(GPIO_51, UP_20K), PAD_NC(GPIO_52, UP_20K), PAD_NC(GPIO_53, UP_20K), PAD_NC(GPIO_67, UP_20K),
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34364 )
Change subject: mb/google/octopus/variants/fleex: Remove gpio NC setting for enabling I2C0 ......................................................................
Patch Set 1: Code-Review+1
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34364 )
Change subject: mb/google/octopus/variants/fleex: Remove gpio NC setting for enabling I2C0 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34364/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/fleex/gpio.c:
https://review.coreboot.org/c/coreboot/+/34364/1/src/mainboard/google/octopu... PS1, Line 25: Any impact on Fleex configuring these GPIOs? Hopefully no spurious signals are received.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34364 )
Change subject: mb/google/octopus/variants/fleex: Remove gpio NC setting for enabling I2C0 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34364/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/fleex/gpio.c:
https://review.coreboot.org/c/coreboot/+/34364/1/src/mainboard/google/octopu... PS1, Line 25:
Any impact on Fleex configuring these GPIOs? Hopefully no spurious signals are received.
Also any power consumption concern?
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34364 )
Change subject: mb/google/octopus/variants/fleex: Remove gpio NC setting for enabling I2C0 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34364/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/fleex/gpio.c:
https://review.coreboot.org/c/coreboot/+/34364/1/src/mainboard/google/octopu... PS1, Line 25:
Also any power consumption concern?
I2C0 is only used in Grob360S for EMR function. There are no i2c devices on I2C0 for rest fleex-related projects.
For power consumption, we will co-work with our HW team to measure it later. There is no sku id for Grob360S yet. I can configure it with sku ids if the Grob360S's sku id is determined.
More info for reference: https://partnerissuetracker.corp.google.com/issues/135968368
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34364 )
Change subject: mb/google/octopus/variants/fleex: Remove gpio NC setting for enabling I2C0 ......................................................................
Patch Set 1:
Hi Google,
Could you help review the CL? We would like to verify EMR function with CPFE FW image later. Thank you.
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34364 )
Change subject: mb/google/octopus/variants/fleex: Remove gpio NC setting for enabling I2C0 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34364/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/fleex/gpio.c:
https://review.coreboot.org/c/coreboot/+/34364/1/src/mainboard/google/octopu... PS1, Line 25:
I2C0 is only used in Grob360S for EMR function. […]
Add more info. After having a discussion with our HW team, the i2c0 in previous fleex-related projects are not connected to any i2c devices. The power consumption should be few uW even if the i2c0 is enabled. I think it is harmless.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34364 )
Change subject: mb/google/octopus/variants/fleex: Remove gpio NC setting for enabling I2C0 ......................................................................
Patch Set 1: Code-Review+2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34364 )
Change subject: mb/google/octopus/variants/fleex: Remove gpio NC setting for enabling I2C0 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34364/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/fleex/gpio.c:
https://review.coreboot.org/c/coreboot/+/34364/1/src/mainboard/google/octopu... PS1, Line 25:
Add more info. […]
Done
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34364 )
Change subject: mb/google/octopus/variants/fleex: Remove gpio NC setting for enabling I2C0 ......................................................................
Patch Set 1:
Please help merge to FW branch. We are finish the factory build, we need official FW for further testing.
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34364 )
Change subject: mb/google/octopus/variants/fleex: Remove gpio NC setting for enabling I2C0 ......................................................................
mb/google/octopus/variants/fleex: Remove gpio NC setting for enabling I2C0
Enable I2C0 in fleex then verify EMR function successfully
BUG=b:135968368 BRANCH=octopus TEST=EMR function working normally with I2C0 in Grob360S.
Change-Id: I784ff32418bc839bcec14fbfd7236f708828690e Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34364 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marco Chen marcochen@google.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/octopus/variants/fleex/gpio.c 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Marco Chen: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/fleex/gpio.c b/src/mainboard/google/octopus/variants/fleex/gpio.c index d2d0d64..a1e02d2 100644 --- a/src/mainboard/google/octopus/variants/fleex/gpio.c +++ b/src/mainboard/google/octopus/variants/fleex/gpio.c @@ -21,8 +21,6 @@
static const struct pad_config default_override_table[] = {
- PAD_NC(GPIO_50, UP_20K), - PAD_NC(GPIO_51, UP_20K), PAD_NC(GPIO_52, UP_20K), PAD_NC(GPIO_53, UP_20K), PAD_NC(GPIO_67, UP_20K),
-
EricR Lai (Code Review) -
Frank Wu (Code Review)
-
Furquan Shaikh (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Marco Chen (Code Review)