Change in coreboot[master]: soc/mediatek/mt8186: Set RTC capid to 0xC0 to pass XTAL 26MHz test - coreboot-gerrit

1 Mar 2022


      Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Paul Menzel.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62290 )
Change subject: soc/mediatek/mt8186: Set RTC capid to 0xC0 to pass XTAL 26MHz test
......................................................................
Patch Set 6:
(1 comment)
File src/soc/mediatek/mt8186/rtc.c:
https://review.coreboot.org/c/coreboot/+/62290/comment/06484073_21c5381b 
PS6, Line 16: ((1 << 13) - (1 << 8))
Can we use the GENMASK() macro?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62290
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16ab46a5697d304e8001de231ffc9b7b7a2f9282
Gerrit-Change-Number: 62290
Gerrit-PatchSet: 6
Gerrit-Owner: Rex-BC Chen rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Rex-BC Chen rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Rex-BC Chen rex-bc.chen@mediatek.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 01 Mar 2022 03:12:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment