Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Kyösti Mälkki. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55088 )
Change subject: drivers/i2c/designware: Report I2C timings for additional bus speeds ......................................................................
Patch Set 2:
(1 comment)
File src/drivers/i2c/designware/dw_i2c.c:
https://review.coreboot.org/c/coreboot/+/55088/comment/b366e88b_f13fcc9e PS2, Line 834: Now check if there are more speed settings available and report them as well.
Would it be bad to expose information about all different I2C speeds to the OS? We can skip the ones […]
The reason I took this approach is that I would like to avoid invalid values being reported. With the current patch only the timings, that a mainboard explicitly provides in addition to the used one will be reported. This means that the developer needs to be active to add these additional timings where we have a higher chance that they are valid or even were measured to assure their validity. If we apply a generic set of timings, chances are way higher that there will bu "dummy" timings not matching the real hardware very soon.