Attention is currently required from: Michał Żygowski, Michał Kopeć. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63656 )
Change subject: mb/msi/ms7d25: Configure PCIe Root Ports ......................................................................
Patch Set 11: Verified-1
(57 comments)
File src/mainboard/msi/ms7d25/gpio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/fce16af8_04bdd57d PS11, Line 142: _PAD_CFG_STRUCT(VGPIO_4, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/c0642d91_02d93b17 PS11, Line 172: _PAD_CFG_STRUCT(VGPIO_USB_0, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_0 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/d94315d4_0bb22852 PS11, Line 172: _PAD_CFG_STRUCT(VGPIO_USB_0, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_0 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/5d328a45_d19ff14d PS11, Line 173: _PAD_CFG_STRUCT(VGPIO_USB_1, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/090851c5_93f7740d PS11, Line 173: _PAD_CFG_STRUCT(VGPIO_USB_1, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_1 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/37ffd100_d1f331d7 PS11, Line 174: _PAD_CFG_STRUCT(VGPIO_USB_2, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_2 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/f8474db4_a13a5044 PS11, Line 174: _PAD_CFG_STRUCT(VGPIO_USB_2, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_2 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/4eef7b87_7a9858a9 PS11, Line 175: _PAD_CFG_STRUCT(VGPIO_USB_3, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/1900358c_37d0de4c PS11, Line 175: _PAD_CFG_STRUCT(VGPIO_USB_3, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_3 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/c7e13fc5_a0cf74ad PS11, Line 176: _PAD_CFG_STRUCT(VGPIO_USB_8, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_8 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/34e8f7da_5d8e7ab8 PS11, Line 176: _PAD_CFG_STRUCT(VGPIO_USB_8, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_8 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/fac9166b_82bd6055 PS11, Line 177: _PAD_CFG_STRUCT(VGPIO_USB_9, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_9 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/18176197_73e36f2c PS11, Line 177: _PAD_CFG_STRUCT(VGPIO_USB_9, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_9 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/10eca28f_e704c691 PS11, Line 178: _PAD_CFG_STRUCT(VGPIO_USB_10, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_10 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/c8ef9924_8943d0d3 PS11, Line 178: _PAD_CFG_STRUCT(VGPIO_USB_10, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_10 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/7d28c7e1_0d77967d PS11, Line 179: _PAD_CFG_STRUCT(VGPIO_USB_11, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_11 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/df5eb582_aab20445 PS11, Line 179: _PAD_CFG_STRUCT(VGPIO_USB_11, PAD_FUNC(NF1) | PAD_RESET(DEEP)| PAD_CFG_GPIO_NAF_VWE, 0), /* VGPIO_USB_11 */ need consistent spacing around '|' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/c85e5ce4_4b87f4d4 PS11, Line 425: // _PAD_CFG_STRUCT(VGPIO_PCIE_0, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/48df5e8d_5c98d0b3 PS11, Line 426: // _PAD_CFG_STRUCT(VGPIO_PCIE_1, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/9b9ca027_1b6362bb PS11, Line 427: // _PAD_CFG_STRUCT(VGPIO_PCIE_2, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/101e0bcd_025e9477 PS11, Line 428: // _PAD_CFG_STRUCT(VGPIO_PCIE_3, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/653436ae_a4f95e6c PS11, Line 429: // _PAD_CFG_STRUCT(VGPIO_PCIE_4, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/a681cc9a_0bee8dc4 PS11, Line 430: // _PAD_CFG_STRUCT(VGPIO_PCIE_5, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/7830f5c6_322fd306 PS11, Line 431: // _PAD_CFG_STRUCT(VGPIO_PCIE_6, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/c8719bb5_e60f5222 PS11, Line 432: // _PAD_CFG_STRUCT(VGPIO_PCIE_7, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/af228507_82fe0038 PS11, Line 433: // _PAD_CFG_STRUCT(VGPIO_PCIE_8, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/b16dc6d4_10f3439d PS11, Line 434: // _PAD_CFG_STRUCT(VGPIO_PCIE_9, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/92617c4c_50e76f20 PS11, Line 435: // _PAD_CFG_STRUCT(VGPIO_PCIE_10, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/3cc6e619_8861d0ef PS11, Line 436: // _PAD_CFG_STRUCT(VGPIO_PCIE_11, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/a2d02efe_e0685a9c PS11, Line 437: // _PAD_CFG_STRUCT(VGPIO_PCIE_12, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/38c52aec_1af296d0 PS11, Line 438: // _PAD_CFG_STRUCT(VGPIO_PCIE_13, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/fb229abe_f4ca0795 PS11, Line 439: // _PAD_CFG_STRUCT(VGPIO_PCIE_14, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/c9723e48_c2c91564 PS11, Line 440: // _PAD_CFG_STRUCT(VGPIO_PCIE_15, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/78c033d8_8ab885f0 PS11, Line 441: // _PAD_CFG_STRUCT(VGPIO_PCIE_64, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/f3d69c12_3cc837e7 PS11, Line 442: // _PAD_CFG_STRUCT(VGPIO_PCIE_65, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/59bd5c2b_8d739b0a PS11, Line 443: // _PAD_CFG_STRUCT(VGPIO_PCIE_66, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/56327865_45f91d72 PS11, Line 444: // _PAD_CFG_STRUCT(VGPIO_PCIE_67, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/c32c8b3c_d73feeb4 PS11, Line 447: // _PAD_CFG_STRUCT(VGPIO_PCIE_16, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/74992595_eb9f9365 PS11, Line 448: // _PAD_CFG_STRUCT(VGPIO_PCIE_17, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/5cfbfa0e_e826c58e PS11, Line 449: // _PAD_CFG_STRUCT(VGPIO_PCIE_18, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/0a00f6ec_050ebddc PS11, Line 450: // _PAD_CFG_STRUCT(VGPIO_PCIE_19, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/0fde2aec_2d8233ca PS11, Line 451: // _PAD_CFG_STRUCT(VGPIO_PCIE_20, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/aca225d4_409ce92c PS11, Line 452: // _PAD_CFG_STRUCT(VGPIO_PCIE_21, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/45259927_a9ea29d4 PS11, Line 453: // _PAD_CFG_STRUCT(VGPIO_PCIE_22, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/f5a356d5_1c768681 PS11, Line 454: // _PAD_CFG_STRUCT(VGPIO_PCIE_23, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/b6735ae0_b78cf45f PS11, Line 455: // _PAD_CFG_STRUCT(VGPIO_PCIE_24, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/35852db7_35561f78 PS11, Line 456: // _PAD_CFG_STRUCT(VGPIO_PCIE_25, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/62c85fcf_7f45a93d PS11, Line 457: // _PAD_CFG_STRUCT(VGPIO_PCIE_26, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/7f8c979d_a902e744 PS11, Line 458: // _PAD_CFG_STRUCT(VGPIO_PCIE_27, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/3bb8dd5f_fa5ef068 PS11, Line 459: // _PAD_CFG_STRUCT(VGPIO_PCIE_28, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/a7a557a3_7d02e818 PS11, Line 460: // _PAD_CFG_STRUCT(VGPIO_PCIE_29, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/5de6f9ef_12af8799 PS11, Line 461: // _PAD_CFG_STRUCT(VGPIO_PCIE_30, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/49750262_1c58de84 PS11, Line 462: // _PAD_CFG_STRUCT(VGPIO_PCIE_31, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/f1f560c4_c827bd90 PS11, Line 463: // _PAD_CFG_STRUCT(VGPIO_PCIE_68, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/1cd7da9b_5d1627a0 PS11, Line 464: // _PAD_CFG_STRUCT(VGPIO_PCIE_69, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/200314da_355e42b7 PS11, Line 465: // _PAD_CFG_STRUCT(VGPIO_PCIE_70, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150284): https://review.coreboot.org/c/coreboot/+/63656/comment/c659aca7_b2edc4a9 PS11, Line 466: // _PAD_CFG_STRUCT(VGPIO_PCIE_71, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_CFG_GPIO_NAF_VWE, 0), line over 96 characters