Change in coreboot[master]: mb/google/zork/var/ezkinil: Fix GPIO_86 configuration for bid3
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42940 )
Change subject: mb/google/zork/var/ezkinil: Fix GPIO_86 configuration for bid3 ......................................................................
mb/google/zork/var/ezkinil: Fix GPIO_86 configuration for bid3
Board version 3 for Ezkinil follows Trembyle reference v3.51 schematics and hence GPIO_86 does not need a variant specific override.
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I7e04baad976f94d0d94e7196f0408c3c3237b2da --- M src/mainboard/google/zork/variants/ezkinil/gpio.c 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/42940/1
diff --git a/src/mainboard/google/zork/variants/ezkinil/gpio.c b/src/mainboard/google/zork/variants/ezkinil/gpio.c index 2d6ebe7..d8c8edd 100644 --- a/src/mainboard/google/zork/variants/ezkinil/gpio.c +++ b/src/mainboard/google/zork/variants/ezkinil/gpio.c @@ -40,8 +40,6 @@ PAD_GPI(GPIO_11, PULL_UP), /* FPMCU_BOOT0 Change NC */ PAD_GPI(GPIO_69, PULL_UP), - /* MST_GPIO_2 (Fw Update HDMI hub) Change NC */ - PAD_GPI(GPIO_86, PULL_UP), };
const struct soc_amd_gpio *variant_override_gpio_table(size_t *size)
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42940 )
Change subject: mb/google/zork/var/ezkinil: Fix GPIO_86 configuration for bid3 ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42940 )
Change subject: mb/google/zork/var/ezkinil: Fix GPIO_86 configuration for bid3 ......................................................................
mb/google/zork/var/ezkinil: Fix GPIO_86 configuration for bid3
Board version 3 for Ezkinil follows Trembyle reference v3.51 schematics and hence GPIO_86 does not need a variant specific override.
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I7e04baad976f94d0d94e7196f0408c3c3237b2da Reviewed-on: https://review.coreboot.org/c/coreboot/+/42940 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/mainboard/google/zork/variants/ezkinil/gpio.c 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/ezkinil/gpio.c b/src/mainboard/google/zork/variants/ezkinil/gpio.c index 2d6ebe7..d8c8edd 100644 --- a/src/mainboard/google/zork/variants/ezkinil/gpio.c +++ b/src/mainboard/google/zork/variants/ezkinil/gpio.c @@ -40,8 +40,6 @@ PAD_GPI(GPIO_11, PULL_UP), /* FPMCU_BOOT0 Change NC */ PAD_GPI(GPIO_69, PULL_UP), - /* MST_GPIO_2 (Fw Update HDMI hub) Change NC */ - PAD_GPI(GPIO_86, PULL_UP), };
const struct soc_amd_gpio *variant_override_gpio_table(size_t *size)
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)