Rob Barnes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46601 )
Change subject: mb/google/zork/woomax: Adjust disconnect threshold ......................................................................
mb/google/zork/woomax: Adjust disconnect threshold
The disconnect voltage needs to be adjusted up because the HS DC voltage level is 0xF.
BUG=b:170879690 TEST=Servo_v4 USB hub functions BRANCH=zork
Change-Id: If8662015a45c57e457b4593e55af888084842f58 Signed-off-by: Rob Barnes robbarnes@google.com --- M src/mainboard/google/zork/variants/woomax/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/46601/1
diff --git a/src/mainboard/google/zork/variants/woomax/overridetree.cb b/src/mainboard/google/zork/variants/woomax/overridetree.cb index 19d66fc..e9d66f9 100644 --- a/src/mainboard/google/zork/variants/woomax/overridetree.cb +++ b/src/mainboard/google/zork/variants/woomax/overridetree.cb @@ -24,7 +24,7 @@ # End : OPN Performance Configuration #USB 2.0 strength register "usb_2_port_tune_params[0]" = "{ - .com_pds_tune = 0x03, + .com_pds_tune = 0x07, .sq_rx_tune = 0x3, .tx_fsls_tune = 0x3, .tx_pre_emp_amp_tune = 0x03, @@ -36,7 +36,7 @@ }"
register "usb_2_port_tune_params[3]" = "{ - .com_pds_tune = 0x03, + .com_pds_tune = 0x07, .sq_rx_tune = 0x3, .tx_fsls_tune = 0x3, .tx_pre_emp_amp_tune = 0x03,
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46601 )
Change subject: mb/google/zork/woomax: Adjust disconnect threshold ......................................................................
Patch Set 1: Code-Review+1
did you or someone else run a signal integrity test with this patch applied?
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46601 )
Change subject: mb/google/zork/woomax: Adjust disconnect threshold ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
did you or someone else run a signal integrity test with this patch applied?
No, waiting on ODM
Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46601 )
Change subject: mb/google/zork/woomax: Adjust disconnect threshold ......................................................................
Patch Set 1:
We had verify USB signal integrity . The result is passed .
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46601 )
Change subject: mb/google/zork/woomax: Adjust disconnect threshold ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46601 )
Change subject: mb/google/zork/woomax: Adjust disconnect threshold ......................................................................
mb/google/zork/woomax: Adjust disconnect threshold
The disconnect voltage needs to be adjusted up because the HS DC voltage level is 0xF.
BUG=b:170879690 TEST=Servo_v4 USB hub functions BRANCH=zork
Change-Id: If8662015a45c57e457b4593e55af888084842f58 Signed-off-by: Rob Barnes robbarnes@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46601 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/google/zork/variants/woomax/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/woomax/overridetree.cb b/src/mainboard/google/zork/variants/woomax/overridetree.cb index 19d66fc..e9d66f9 100644 --- a/src/mainboard/google/zork/variants/woomax/overridetree.cb +++ b/src/mainboard/google/zork/variants/woomax/overridetree.cb @@ -24,7 +24,7 @@ # End : OPN Performance Configuration #USB 2.0 strength register "usb_2_port_tune_params[0]" = "{ - .com_pds_tune = 0x03, + .com_pds_tune = 0x07, .sq_rx_tune = 0x3, .tx_fsls_tune = 0x3, .tx_pre_emp_amp_tune = 0x03, @@ -36,7 +36,7 @@ }"
register "usb_2_port_tune_params[3]" = "{ - .com_pds_tune = 0x03, + .com_pds_tune = 0x07, .sq_rx_tune = 0x3, .tx_fsls_tune = 0x3, .tx_pre_emp_amp_tune = 0x03,
-
Felix Held (Code Review) -
Ken Lu (Code Review)
-
Rob Barnes (Code Review)