Change in coreboot[master]: drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Jes Klinke (Code Review)

1 Dec 2020 1 Dec '20

3:25 p.m.

Jes Klinke has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48222 )

Change subject: drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node ......................................................................

drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node

Volteer has two "sub-variants" sharing the same overridetree.cb, one having I2C TPM and another having I2C TPM. The former will have a disabled ACPI node representing the I2C TPM, while its Kconfig is such that coreboot itself does not have I2C TPM support.

In order to export even a disabled ACPI node representing the I2C connected TPM, coreboot needs DRIVER_I2C_TPM_ACPI. Hence, that will have to be enabled in a case where coreboot does not have I2C_TPM.

BUG=b:173461736 TEST=Tested as part of next CL in chain

Change-Id: I9717f6b68afd90fbc294fbbd2a5b8d0c6ee9ae55 Signed-off-by: Jes Bodi Klinke jbk@chromium.org --- M src/drivers/i2c/tpm/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/48222/1

diff --git a/src/drivers/i2c/tpm/Kconfig b/src/drivers/i2c/tpm/Kconfig index 6a27224..e0f7fbf 100644 --- a/src/drivers/i2c/tpm/Kconfig +++ b/src/drivers/i2c/tpm/Kconfig @@ -41,7 +41,6 @@ depends on I2C_TPM

config DRIVER_I2C_TPM_ACPI - depends on I2C_TPM bool "Generate I2C TPM ACPI device" default y if ARCH_X86 && I2C_TPM default n

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Furquan Shaikh (Code Review)

1 Dec 1 Dec

3:31 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48222 )

Change subject: drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/48222/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48222/1//COMMIT_MSG@8 PS1, Line 8: I think it will be good to add some information here explaining that the reason why DRIVER_I2C_TPM_ACPI was made dependent on I2C_TPM was to hide it from menuconfig if I2C_TPM was not selected. The same can be achieved by adding a conditional on the prompt for the config. So, there should not be any functional or build time change because of this CL.

https://review.coreboot.org/c/coreboot/+/48222/1/src/drivers/i2c/tpm/Kconfig File src/drivers/i2c/tpm/Kconfig:

https://review.coreboot.org/c/coreboot/+/48222/1/src/drivers/i2c/tpm/Kconfig... PS1, Line 44: " if I2C_TPM

to ensure that the Kconfig is not visible in menuconfig unless I2C_TPM is selected.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9717f6b68afd90fbc294fbbd2a5b8d0c6ee9ae55 Gerrit-Change-Number: 48222 Gerrit-PatchSet: 1 Gerrit-Owner: Jes Klinke jbk@chromium.org Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Tue, 01 Dec 2020 23:31:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jes Klinke (Code Review)

3:53 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Christian Walter,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48222

to look at the new patch set (#2).

Change subject: drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node ......................................................................

drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node

BUG=b:173461736 TEST=Tested as part of next CL in chain

Change-Id: I9717f6b68afd90fbc294fbbd2a5b8d0c6ee9ae55 Signed-off-by: Jes Bodi Klinke jbk@chromium.org --- M src/drivers/i2c/tpm/Kconfig 1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/48222/2

Furquan Shaikh (Code Review)

5:05 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48222 )

Change subject: drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48222/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48222/1//COMMIT_MSG@8 PS1, Line 8:

...

I think it will be good to add some information here explaining that the reason why DRIVER_I2C_TPM_A […]

Can you please address this as well?

-- To view, visit https://review.coreboot.org/c/coreboot/+/48222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9717f6b68afd90fbc294fbbd2a5b8d0c6ee9ae55 Gerrit-Change-Number: 48222 Gerrit-PatchSet: 2 Gerrit-Owner: Jes Klinke jbk@chromium.org Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 02 Dec 2020 01:05:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Jes Klinke (Code Review)

3 Dec 3 Dec

9:01 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Christian Walter,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48222

to look at the new patch set (#3).

Change subject: drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node ......................................................................

drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node

DRIVER_I2C_TPM_ACPI is used to enable the "driver" needed for coreboot to present a TPM node in the devicetree. It would usually only do so, if coreboot itself is communicating with the TPM via I2C (I2C_TPM). However, technically, there is no dependency.

In order to not show the ACPI option i nmenuconfig if the board is not using I2C, a dependency was declared in Kconfig. However, the same can be achieved without making it an error to manually declare DRIVER_I2C_TPM_ACPI without I2C_TPM.

For Volteer, we have just such a need, since it has two "sub-variants" sharing the same overridetree.cb, one having I2C TPM and another having I2C TPM. The former will have a disabled ACPI node representing the I2C TPM, while its Kconfig is such that coreboot itself does not have I2C TPM support.

BUG=b:173461736 TEST=Tested as part of next CL in chain

Change-Id: I9717f6b68afd90fbc294fbbd2a5b8d0c6ee9ae55 Signed-off-by: Jes Bodi Klinke jbk@chromium.org --- M src/drivers/i2c/tpm/Kconfig 1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/48222/3

Jes Klinke (Code Review)

9:01 a.m.

Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48222 )

Change subject: drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node ......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/48222/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48222/1//COMMIT_MSG@8 PS1, Line 8:

...

Can you please address this as well?

Done

https://review.coreboot.org/c/coreboot/+/48222/1/src/drivers/i2c/tpm/Kconfig File src/drivers/i2c/tpm/Kconfig:

https://review.coreboot.org/c/coreboot/+/48222/1/src/drivers/i2c/tpm/Kconfig... PS1, Line 44: "

...

if I2C_TPM […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/48222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9717f6b68afd90fbc294fbbd2a5b8d0c6ee9ae55 Gerrit-Change-Number: 48222 Gerrit-PatchSet: 3 Gerrit-Owner: Jes Klinke jbk@chromium.org Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 03 Dec 2020 17:01:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

11:13 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48222 )

Change subject: drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node ......................................................................

Patch Set 3: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/48222/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48222/3//COMMIT_MSG@14 PS3, Line 14: i n in

-- To view, visit https://review.coreboot.org/c/coreboot/+/48222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9717f6b68afd90fbc294fbbd2a5b8d0c6ee9ae55 Gerrit-Change-Number: 48222 Gerrit-PatchSet: 3 Gerrit-Owner: Jes Klinke jbk@chromium.org Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 03 Dec 2020 19:13:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jes Klinke (Code Review)

4 Dec 4 Dec

1:27 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Christian Walter,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48222

to look at the new patch set (#4).

Change subject: drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node ......................................................................

drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node

In order to not show the ACPI option in menuconfig if the board is not using I2C, a dependency was declared in Kconfig. However, the same can be achieved without making it an error to manually declare DRIVER_I2C_TPM_ACPI without I2C_TPM.

BUG=b:173461736 TEST=Tested as part of next CL in chain

Change-Id: I9717f6b68afd90fbc294fbbd2a5b8d0c6ee9ae55 Signed-off-by: Jes Bodi Klinke jbk@chromium.org --- M src/drivers/i2c/tpm/Kconfig 1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/48222/4

Jes Klinke (Code Review)

1:28 p.m.

Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48222 )

Change subject: drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48222/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48222/3//COMMIT_MSG@14 PS3, Line 14: i n

...

in

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/48222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9717f6b68afd90fbc294fbbd2a5b8d0c6ee9ae55 Gerrit-Change-Number: 48222 Gerrit-PatchSet: 4 Gerrit-Owner: Jes Klinke jbk@chromium.org Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 04 Dec 2020 21:28:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

7 Dec 7 Dec

6:05 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48222 )

Change subject: drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48222/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48222/4//COMMIT_MSG@20 PS4, Line 20: one having I2C TPM and another having : I2C TPM two sub variants both having i2c tpm, what's the problem?

-- To view, visit https://review.coreboot.org/c/coreboot/+/48222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9717f6b68afd90fbc294fbbd2a5b8d0c6ee9ae55 Gerrit-Change-Number: 48222 Gerrit-PatchSet: 4 Gerrit-Owner: Jes Klinke jbk@chromium.org Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Mon, 07 Dec 2020 14:05:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jes Klinke (Code Review)

9:18 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Christian Walter,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48222

to look at the new patch set (#5).

Change subject: drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node ......................................................................

drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node

In order to not show the ACPI option in menuconfig if the board is not using I2C, a dependency was declared in Kconfig. However, the same can be achieved without making it an error to manually declare DRIVER_I2C_TPM_ACPI without I2C_TPM.

For Volteer, we have just such a need, since it has two "sub-variants" sharing the same overridetree.cb, one having SPI TPM and another having I2C TPM. The former will have a disabled ACPI node representing the I2C TPM, while its Kconfig is such that coreboot itself does not have I2C TPM support.

BUG=b:173461736 TEST=Tested as part of next CL in chain

Change-Id: I9717f6b68afd90fbc294fbbd2a5b8d0c6ee9ae55 Signed-off-by: Jes Bodi Klinke jbk@chromium.org --- M src/drivers/i2c/tpm/Kconfig 1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/48222/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/48222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9717f6b68afd90fbc294fbbd2a5b8d0c6ee9ae55 Gerrit-Change-Number: 48222 Gerrit-PatchSet: 5 Gerrit-Owner: Jes Klinke jbk@chromium.org Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: newpatchset

Jes Klinke (Code Review)

9:20 a.m.

Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48222 )

Change subject: drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48222/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48222/4//COMMIT_MSG@20 PS4, Line 20: one having I2C TPM and another having : I2C TPM

...

two sub variants both having i2c tpm, what's the problem?

Thanks for pointing this out. I meant one sub-variant using SPI, another using I2C.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9717f6b68afd90fbc294fbbd2a5b8d0c6ee9ae55 Gerrit-Change-Number: 48222 Gerrit-PatchSet: 5 Gerrit-Owner: Jes Klinke jbk@chromium.org Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Mon, 07 Dec 2020 17:20:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

8 Dec 8 Dec

8:54 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48222 )

Change subject: drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node ......................................................................

drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node

In order to not show the ACPI option in menuconfig if the board is not using I2C, a dependency was declared in Kconfig. However, the same can be achieved without making it an error to manually declare DRIVER_I2C_TPM_ACPI without I2C_TPM.

BUG=b:173461736 TEST=Tested as part of next CL in chain

Change-Id: I9717f6b68afd90fbc294fbbd2a5b8d0c6ee9ae55 Signed-off-by: Jes Bodi Klinke jbk@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/48222 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/i2c/tpm/Kconfig 1 file changed, 1 insertion(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/drivers/i2c/tpm/Kconfig b/src/drivers/i2c/tpm/Kconfig index 6a27224..df622f0 100644 --- a/src/drivers/i2c/tpm/Kconfig +++ b/src/drivers/i2c/tpm/Kconfig @@ -41,8 +41,7 @@ depends on I2C_TPM

config DRIVER_I2C_TPM_ACPI - depends on I2C_TPM - bool "Generate I2C TPM ACPI device" + bool "Generate I2C TPM ACPI device" if I2C_TPM default y if ARCH_X86 && I2C_TPM default n

-- To view, visit https://review.coreboot.org/c/coreboot/+/48222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9717f6b68afd90fbc294fbbd2a5b8d0c6ee9ae55 Gerrit-Change-Number: 48222 Gerrit-PatchSet: 6 Gerrit-Owner: Jes Klinke jbk@chromium.org Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

Nico Huber (Code Review)

9 Dec 9 Dec

12:01 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48222 )

Change subject: drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48222/6/src/drivers/i2c/tpm/Kconfig File src/drivers/i2c/tpm/Kconfig:

https://review.coreboot.org/c/coreboot/+/48222/6/src/drivers/i2c/tpm/Kconfig... PS6, Line 44: bool "Generate I2C TPM ACPI device" if I2C_TPM This change made me wonder, why does it have a prompt? It seems it is either required for a successful build or not used at all?

-- To view, visit https://review.coreboot.org/c/coreboot/+/48222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9717f6b68afd90fbc294fbbd2a5b8d0c6ee9ae55 Gerrit-Change-Number: 48222 Gerrit-PatchSet: 6 Gerrit-Owner: Jes Klinke jbk@chromium.org Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Wed, 09 Dec 2020 20:01:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

1:41 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48222 )

Change subject: drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48222/6/src/drivers/i2c/tpm/Kconfig File src/drivers/i2c/tpm/Kconfig:

https://review.coreboot.org/c/coreboot/+/48222/6/src/drivers/i2c/tpm/Kconfig... PS6, Line 44: bool "Generate I2C TPM ACPI device" if I2C_TPM

...

This change made me wonder, why does it have a prompt? It seems it is either […]

Good point. The prompt isn't really required.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9717f6b68afd90fbc294fbbd2a5b8d0c6ee9ae55 Gerrit-Change-Number: 48222 Gerrit-PatchSet: 6 Gerrit-Owner: Jes Klinke jbk@chromium.org Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Wed, 09 Dec 2020 21:41:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

1514

days inactive

1522

days old

coreboot-gerrit@coreboot.org

14 comments

4 participants

tags (0)

participants (4)

Furquan Shaikh (Code Review)
Jes Klinke (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)