Attention is currently required from: Bob Moragues, Bora Guvendik, Cliff Huang, Eric Lai, Hannah Williams, Poornima Tom, Ravishankar Sarawadi, Subrata Banik, YH Lin, dinesh.sharma@intel.com.
Jérémy Compostella has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/81790?usp=email )
Change subject: drivers/wifi: Support 320Mhz Bandwidth Enablement per MCC
......................................................................
Patch Set 11:
(3 comments)
File src/drivers/wifi/generic/acpi.c:
https://review.coreboot.org/c/coreboot/+/81790/comment/3c771358_c4b14d2d?usp... :
PS10, Line 542: s
should be `const` as well?
Done
File src/include/sar.h:
https://review.coreboot.org/c/coreboot/+/81790/comment/2ba3fc17_4b775293?usp... :
PS10, Line 15: WBEM_REVISION
which spec should decide if the revision may see an uprev in future ?
Document #559910 Intel Connectivity Platforms BIOS Guidelines define the WBEM table and it revisions. It currently support a single WBEM revision (revision 0).
The revision required for the platform would depend on system and requirement definitions.
https://review.coreboot.org/c/coreboot/+/81790/comment/770c2b0a_0955f174?usp... :
PS10, Line 15: WBEM_REVISION
which spec should decide if the revision may see an uprev in future ?
Document #559910 Intel Connectivity Platforms BIOS Guidelines define all the variation / revision available. There is a currently just a single revision for WBEM.
The uprev decision would come a board / system requirement. Like an extra needed field if it ever happen on day.
I did not use the `MAX_WBEM_REVISION` approach because it does not make sense at this stage and that's something which can be done depending on how requirements evolve in the future.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81790?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie76794825f1a0104d199c078aa4ffc714aa95b17
Gerrit-Change-Number: 81790
Gerrit-PatchSet: 11
Gerrit-Owner: Poornima Tom
poornima.tom@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: dinesh.sharma@intel.com
Gerrit-CC: Bob Moragues
moragues@google.com
Gerrit-CC: Dinesh Sharma
dinesh.sharma@intel.corp-partner.google.com
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-CC: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Poornima Tom
poornima.tom@intel.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: dinesh.sharma@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Comment-Date: Tue, 02 Jul 2024 16:38:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com