build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45210 )
Change subject: soc/intel/cannonlake: rename "RSVD" GPIOs to their correct names
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45210/5/src/soc/intel/cannonlake/in...
File src/soc/intel/cannonlake/include/soc/gpio_soc_defs_cnp_h.h:
https://review.coreboot.org/c/coreboot/+/45210/5/src/soc/intel/cannonlake/in...
PS5, Line 316: #define PECI 253
please, no space before tabs
https://review.coreboot.org/c/coreboot/+/45210/5/src/soc/intel/cannonlake/in...
PS5, Line 317: #define CPUPWRGD 254
please, no space before tabs
https://review.coreboot.org/c/coreboot/+/45210/5/src/soc/intel/cannonlake/in...
PS5, Line 321: #define TRIGGER_IN 258
please, no space before tabs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45210
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59df09c8fd464e75f918455aa1972765abc51459
Gerrit-Change-Number: 45210
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 11 Sep 2020 21:38:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment