Attention is currently required from: Felix Singer, Jeff Daly, Martin Roth, Paul Menzel, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60877 )
Change subject: sb/intel/common/firmware: Hook up adding 10GbE LAN firmware ......................................................................
Patch Set 16: Code-Review+1
(2 comments)
File src/southbridge/intel/common/firmware/Kconfig:
https://review.coreboot.org/c/coreboot/+/60877/comment/780e7dc2_627f529d PS13, Line 152: HAVE_
Done
We use the `HAVE_FOO` and `USE_FOO` scheme in other parts of the tree (for example, `MAINBOARD_HAS_LIBGFXINIT` and `MAINBOARD_USE_LIBGFXINIT`). However, looks like some options to add binary files (IFD parts and MRC.bin, to name a few) into the coreboot image don't follow this.
For the IFD parts, the `MAINBOARD_USES_IFD_*_REGION` Kconfig symbol was added much later (originally, the options to add IFD regions would all be visible), which explains why the names aren't consistent.
TL;DR: The naming scheme for the IFD Kconfig options is rather inconsistent, but the names of the options added in this change are consistent with those of the existing options.
File src/southbridge/intel/common/firmware/Kconfig:
https://review.coreboot.org/c/coreboot/+/60877/comment/ba48da6d_5cbe147e PS16, Line 168: depends on MAINBOARD_USES_IFD_10GBE_0_REGION I'd drop this dependency. I don't think there's any mainboard that only uses 10GbE 1 (it would be extremely odd: why not use 10GbE 0?), but I don't see the need to restrict it.
-
Angel Pons (Code Review)