Attention is currently required from: Felix Held, Martin Roth, Zheng Bao.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78274?usp=email )
Change subject: amdfwtool: Set the table size for L1 separately ......................................................................
Patch Set 11:
(3 comments)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/78274/comment/305e92ef_c6527972 : PS11, Line 615: 1
this should probably be changed to TABLE_ALIGNMENT too. that would allow to drop the […]
This patch is only for family which PSP header points to ISH header. I will put this detail in commit log.
https://review.coreboot.org/c/coreboot/+/78274/comment/9601a3a6_baad94f2 : PS11, Line 655: if (cookie == PSP_COOKIE && cb_config->need_ish) : table_size = TABLE_ALIGNMENT; : else
haven't traced the code, but from what i've seen, the actual bug seems to be that in integrate_psp_f […]
In integrate_psp_firmwares the new_ish_dir is called. We can not take the assumption that the increasing pointer is at the end of psp_dir. We have to make sure the ISH header is at the outside of the PSP table. We have to do that when the PSP header is created.
https://review.coreboot.org/c/coreboot/+/78274/comment/c2b89dd5_8a479337 : PS11, Line 1221: 1
this should probably also be changed to TABLE_ALIGNMENT
This patch is only for family which PSP header points to ISH header. I will put this detail in commit log.