Attention is currently required from: Hung-Te Lin, Jarried Lin, Jason-jh Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86027?usp=email )
Change subject: soc/mediatek/mt8196: Add GCE ddren sel control to mminfra
......................................................................
Patch Set 3: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86027/comment/d1891ee6_4d3501f2?usp... :
PS3, Line 12: request
requests
https://review.coreboot.org/c/coreboot/+/86027/comment/8721964a_10587f46?usp... :
PS3, Line 14: Otherwise, GCE will hang when accessing DRAM.
Move the first few words to the previous line
File src/soc/mediatek/mt8196/mminfra.c:
https://review.coreboot.org/c/coreboot/+/86027/comment/557889e4_bfc8ac10?usp... :
PS3, Line 35: 0x1
Maybe just `1` for consistency?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86027?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I30309b0426f803e28858eb15652a649927f94c7e
Gerrit-Change-Number: 86027
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jason-jh Lin
jason-jh.lin@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jason-jh Lin
jason-jh.lin@mediatek.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Fri, 17 Jan 2025 11:05:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes