Attention is currently required from: Kapil Porwal, Ivy Jian, Eric Lai.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67332 )
Change subject: mb/google/rex: Add WWAN poweron sequencing ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/rex/variants/rex0/gpio.c:
https://review.coreboot.org/c/coreboot/+/67332/comment/f8a2847b_17773226 PS1, Line 373: /* GPP_B17 : [] ==> EN_WWAN_PWR */
Enable power pin and assert reset pin is always the require for every power sequence. […]
We're running into some isuses with FP on Brya right now because we forced power on in bootblock. These are the sorts of issues I'm trying to avoid. IMHO, bootblock should be absolute minimum of setup necessary to get through that stage.
https://review.coreboot.org/c/coreboot/+/67332/comment/452a5aa5_a4086942 PS1, Line 425: PAD_CFG_GPO(GPP_E07, 1, DEEP), Have we confirmed timing requirements per the datasheet for the sequencing (ton1, ton2) with non debug (full release) FSP?
Can you share those measurements and include them in the TEST= line?
-
Tarun Tuli (Code Review)