Attention is currently required from: Keith Hui, Kevin Keijzer, Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78205?usp=email )
Change subject: mb/asus/p8z77-m: Fix ACPI S3 suspend ......................................................................
Patch Set 2: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78205/comment/0c46d27c_efe977ec : PS2, Line 7: Fix ACPI S3 suspend : When 3VSBSW# is disabled, the RAM loses power in S3 suspend, so S3 resume fails. So, what this change does can also be summarised as follows:
mb/asus/p8z77-m: Ensure RAM stays powered in S3 suspend
https://review.coreboot.org/c/coreboot/+/78205/comment/c994294c_7c68cfde : PS2, Line 10: S3 suspend totally fails nit: Strictly speaking, it is S3 *resume* that totally fails. The board happily enters S3 suspend, but cannot resume from S3 because the RAM lost power during S3 suspend.
https://review.coreboot.org/c/coreboot/+/78205/comment/a9d8aa73_d5bb3932 : PS2, Line 9: Enable 3VSBSW# in NCT6779D super I/O like other variants in the : family. Without it S3 suspend totally fails.
Maybe also mention the long description (Switch 3VSB power to memory when in S3 state.).
It would be nice to factor in the root cause: S3 resume fails because the RAM was not powered during S3 suspend.
-
Angel Pons (Code Review)