Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36170 )
Change subject: drivers/intel/fsp2_0: Hide the Kconfig option to run FSP-M XIP
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36170/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36170/5//COMMIT_MSG@9
PS5, Line 9: FSP
How so?
This seems to be deep in nitpick territory (of course the CPU's capabilities have an influence on what FSP can do), and given that the comment to FSP_M_XIP states that FSP-M is execute-in-place...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36170
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2086e67d39e88215ee0f124583b810f7df072f80
Gerrit-Change-Number: 36170
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 Nov 2019 14:05:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment