Nico Huber has posted comments on this change. ( https://review.coreboot.org/27218 )
Change subject: southbridge/intel/bd82x6x/Kconfig: Do not include any IFD by default ......................................................................
Patch Set 1:
(1 comment)
HAVE_IFD_BIN is about having the file in the repo. We have the file for the boards that currently don't override the default. So they need an override now.
I would prefer a single commit that inverts the chipset default, adds a `default y` override (or even better `select HAVE_IFD_BIN`) for the affected boards that currently don't have an override and removes all the `default n` board overrides.
https://review.coreboot.org/#/c/27218/1/src/southbridge/intel/bd82x6x/Kconfi... File src/southbridge/intel/bd82x6x/Kconfig:
https://review.coreboot.org/#/c/27218/1/src/southbridge/intel/bd82x6x/Kconfi... PS1, Line 69: config HAVE_IFD_BIN : def_bool n : : config BUILD_WITH_FAKE_IFD : def_bool n Can drop these they should already default to n implicitly.