Change in coreboot[master]: [Try] mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK

List overview All Threads
Download

newer

older

Change in coreboot[master]: [Try]...

HAOUAS Elyes (Code Review)

15 Dec 2019 15 Dec '19

4:25 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37752 )

Change subject: [Try] mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK ......................................................................

[Try] mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK

Untested.

Change-Id: Ib21a1d81629e9ec8d1a78205f926995cbceefe20 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/persimmon/Kconfig M src/mainboard/amd/persimmon/Makefile.inc R src/mainboard/amd/persimmon/bootblock.c 3 files changed, 4 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37752/1

diff --git a/src/mainboard/amd/persimmon/Kconfig b/src/mainboard/amd/persimmon/Kconfig index 005741e..41bf3c9 100644 --- a/src/mainboard/amd/persimmon/Kconfig +++ b/src/mainboard/amd/persimmon/Kconfig @@ -17,7 +17,6 @@

config BOARD_SPECIFIC_OPTIONS def_bool y - select ROMCC_BOOTBLOCK select CPU_AMD_AGESA_FAMILY14 select NORTHBRIDGE_AMD_AGESA_FAMILY14 select SOUTHBRIDGE_AMD_CIMX_SB800 diff --git a/src/mainboard/amd/persimmon/Makefile.inc b/src/mainboard/amd/persimmon/Makefile.inc index ba56286..bf86007 100644 --- a/src/mainboard/amd/persimmon/Makefile.inc +++ b/src/mainboard/amd/persimmon/Makefile.inc @@ -20,6 +20,8 @@ pci$(stripped_ahcibios_id).rom-type := optionrom endif

+bootblock-y += bootblock.c + romstage-y += buildOpts.c romstage-y += BiosCallOuts.c romstage-y += OemCustomize.c diff --git a/src/mainboard/amd/persimmon/romstage.c b/src/mainboard/amd/persimmon/bootblock.c similarity index 84% rename from src/mainboard/amd/persimmon/romstage.c rename to src/mainboard/amd/persimmon/bootblock.c index 7ccf167..6cd9e2a 100644 --- a/src/mainboard/amd/persimmon/romstage.c +++ b/src/mainboard/amd/persimmon/bootblock.c @@ -13,15 +13,13 @@ * GNU General Public License for more details. */

-#include <northbridge/amd/agesa/state_machine.h> +#include <bootblock_common.h> #include <superio/fintek/common/fintek.h> #include <superio/fintek/f81865f/f81865f.h> -#include <sb_cimx.h>

#define SERIAL_DEV PNP_DEV(0x4e, F81865F_SP1)

-void board_BeforeAgesa(struct sysinfo *cb) +void bootblock_mainboard_early_init(void) { - sb_Poweron_Init(); fintek_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE); }

Attachments:

attachment.htm (text/html — 4.5 KB)

Show replies by date

HAOUAS Elyes (Code Review)

16 Dec 16 Dec

10:53 a.m.

New subject: Change in coreboot[master]: mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37752

to look at the new patch set (#2).

Change subject: mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK ......................................................................

mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK

Warning: Not tested on hardware.

Change-Id: Ib21a1d81629e9ec8d1a78205f926995cbceefe20 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/persimmon/Kconfig M src/mainboard/amd/persimmon/Kconfig.name M src/mainboard/amd/persimmon/Makefile.inc R src/mainboard/amd/persimmon/bootblock.c 4 files changed, 6 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37752/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib21a1d81629e9ec8d1a78205f926995cbceefe20 Gerrit-Change-Number: 37752 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

17 Dec 17 Dec

7:44 p.m.

New subject: Change in coreboot[master]: mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37752

to look at the new patch set (#3).

Change subject: mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK ......................................................................

mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK

Warning: Not tested on hardware. To test, please fix the mainbord's Kconfig and Kconfig.name

Change-Id: Ib21a1d81629e9ec8d1a78205f926995cbceefe20 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/persimmon/Makefile.inc R src/mainboard/amd/persimmon/bootblock.c 2 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37752/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/37752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib21a1d81629e9ec8d1a78205f926995cbceefe20 Gerrit-Change-Number: 37752 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Mike Banon (Code Review)

21 Dec 21 Dec

7:36 a.m.

New subject: Change in coreboot[master]: mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK

Mike Banon has uploaded a new patch set (#4) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/37752 )

Change subject: mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK ......................................................................

mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK

Warning: Not tested on hardware.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37752/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/37752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib21a1d81629e9ec8d1a78205f926995cbceefe20 Gerrit-Change-Number: 37752 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Mike Banon (Code Review)

7:36 a.m.

New subject: Change in coreboot[master]: mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK

Mike Banon has uploaded a new patch set (#5) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/37752 )

Change subject: mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK ......................................................................

mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK

Warning: Not tested on hardware.

Change-Id: Ib21a1d81629e9ec8d1a78205f926995cbceefe20 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/persimmon/Kconfig M src/mainboard/amd/persimmon/Kconfig.name M src/mainboard/amd/persimmon/Makefile.inc R src/mainboard/amd/persimmon/bootblock.c 4 files changed, 6 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37752/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/37752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib21a1d81629e9ec8d1a78205f926995cbceefe20 Gerrit-Change-Number: 37752 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

29 Dec 29 Dec

12:33 p.m.

New subject: Change in coreboot[master]: mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37752 )

Change subject: mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK ......................................................................

Patch Set 8:

Mike, rebase on 37951

-- To view, visit https://review.coreboot.org/c/coreboot/+/37752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib21a1d81629e9ec8d1a78205f926995cbceefe20 Gerrit-Change-Number: 37752 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mike Banon mikebdp2@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 29 Dec 2019 11:33:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

30 Dec 30 Dec

3:47 a.m.

New subject: Change in coreboot[master]: [TESTME]mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37752

to look at the new patch set (#10).

Change subject: [TESTME]mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK ......................................................................

[TESTME]mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK

Warning: Not tested on hardware.

Change-Id: Ib21a1d81629e9ec8d1a78205f926995cbceefe20 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/persimmon/Kconfig M src/mainboard/amd/persimmon/Kconfig.name M src/mainboard/amd/persimmon/Makefile.inc R src/mainboard/amd/persimmon/bootblock.c 4 files changed, 6 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37752/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/37752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib21a1d81629e9ec8d1a78205f926995cbceefe20 Gerrit-Change-Number: 37752 Gerrit-PatchSet: 10 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mike Banon mikebdp2@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

7 Jan 7 Jan

5:35 p.m.

New subject: Change in coreboot[master]: [TESTME]mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37752 )

Change subject: [TESTME]mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK ......................................................................

Abandoned

not tested

-- To view, visit https://review.coreboot.org/c/coreboot/+/37752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib21a1d81629e9ec8d1a78205f926995cbceefe20 Gerrit-Change-Number: 37752 Gerrit-PatchSet: 11 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mike Banon mikebdp2@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

HAOUAS Elyes (Code Review)

12 Jan 12 Jan

6:18 p.m.

New subject: Change in coreboot[master]: [TESTME]mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK

HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/37752 )

Change subject: [TESTME]mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK ......................................................................

Restored

-- To view, visit https://review.coreboot.org/c/coreboot/+/37752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib21a1d81629e9ec8d1a78205f926995cbceefe20 Gerrit-Change-Number: 37752 Gerrit-PatchSet: 11 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mike Banon mikebdp2@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: restore

HAOUAS Elyes (Code Review)

4 Feb 4 Feb

9:30 p.m.

New subject: Change in coreboot[master]: [TESTME]mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37752 )

Change subject: [TESTME]mb/amd/persimmon: Switch away from ROMCC_BOOTBLOCK ......................................................................

Abandoned

no one will test ... so drop unmaintained board

-- To view, visit https://review.coreboot.org/c/coreboot/+/37752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib21a1d81629e9ec8d1a78205f926995cbceefe20 Gerrit-Change-Number: 37752 Gerrit-PatchSet: 11 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Mike Banon mikebdp2@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1754

days inactive

1805

days old

coreboot-gerrit@coreboot.org

9 comments

2 participants

tags (0)

participants (2)

HAOUAS Elyes (Code Review)
Mike Banon (Code Review)