Attention is currently required from: Damien Zammit, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62809 )
Change subject: mb/hp/z220_series: Add Z220 CMT Workstation variant
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
Patchset:
PS5:
Jenkins isn't happy for some reason
File src/mainboard/hp/z220_series/variants/z220_cmt_workstation/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62809/comment/c93012bf_1484fde6
PS3, Line 5: subsystemid 0x103c 0x1791 inherit
As per previous commit, yes this line is required to continue the inheritance of the subsystemids.
Hmmm, interesting. Do you mean that, without this line, the devices in the overridetree have the wrong subsystem ID? Interesting.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62809
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b298921e6f509440ec7b049e086c0878f708bd3
Gerrit-Change-Number: 62809
Gerrit-PatchSet: 5
Gerrit-Owner: Damien Zammit
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Sun, 03 Apr 2022 09:47:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Damien Zammit
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment