Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21624 )
Change subject: AGESA: Fix SMM support in ASEG ......................................................................
Patch Set 5:
Currently there are some build problems like
ASUS_AM1I_A build FAILED after 7s! Log excerpt: src/cpu/amd/agesa/family16kb/model_16_init.c: In function 'model_16_init': src/cpu/amd/agesa/family16kb/model_16_init.c:109:15: error: 'MSR_SMM_BASE' undeclared (first use in this function); did you mean 'SMM_BASE'? msr = rdmsr(MSR_SMM_BASE); ^~~~~~~~~~~~ SMM_BASE src/cpu/amd/agesa/family16kb/model_16_init.c:109:15: note: each undeclared identifier is reported only once for each function it appears in src/cpu/amd/agesa/family16kb/model_16_init.c:114:15: error: 'MSR_SMM_MASK' undeclared (first use in this function); did you mean 'PS_STS_MASK'? msr = rdmsr(MSR_SMM_MASK); ^~~~~~~~~~~~ PS_STS_MASK make[1]: *** [Makefile:356: /cb-build/coreboot-gerrit.0/ASUS_AM1I_A/ramstage/cpu/amd/agesa/family16kb/model_16_init.o] Error 1 make[1]: Leaving directory '/home/coreboot/slave-root/workspace/coreboot-gerrit'